From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness
Date: Tue, 21 Jan 2014 12:21:31 +0530 [thread overview]
Message-ID: <52DE18F3.9000002@freescale.com> (raw)
In-Reply-To: <20140121063457.622CC3821EA@gemini.denx.de>
On 1/21/2014 12:04 PM, Wolfgang Denk wrote:
> Dear Scott,
>
> In message <20140121054228.DE99438201D@gemini.denx.de> I wrote:
>> I fear that more IP blocks will follow that have similar requirements,
>> and if we implemnt similar wrappers for each of them separately, we
>> will have a mess of hard to maintain code. For example, it will then
>> be impossible to share common parts of code because driver A uses
>> A_out32() and driver B uses B_out32().
>>
>> We should rather try and find a generic solution where the same
>> functions can be used by mulltiple drivers which have the same needs.
> On second thought, I also think we should avoid solutions where the
> BE/LE test has to be done for each and every I/O accessor call again
> and again. We should rather do this just once, and for example set
> function pointers as needed (hoping that this driver will only be
> needed after relocation, so we have writable data segment).
>
>
Thanks Wolfgang for this suggestion.
As far I understand, you are suggesting to have global structure with
function pointer to accessor function depending upon IP's endiannes..
but i afraid, for IFC we do have scenario where these accessor function
are used before relocation.
Regards,
Prabhakar
next prev parent reply other threads:[~2014-01-21 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 6:58 [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness Prabhakar Kushwaha
2014-01-18 8:24 ` Wolfgang Denk
2014-01-20 22:51 ` Scott Wood
2014-01-21 5:42 ` Wolfgang Denk
2014-01-21 6:34 ` Wolfgang Denk
2014-01-21 6:49 ` York Sun
2014-01-21 9:14 ` Wolfgang Denk
2014-01-21 17:29 ` Scott Wood
2014-01-21 17:34 ` York Sun
2014-01-24 17:57 ` York Sun
2014-01-21 6:51 ` Prabhakar Kushwaha [this message]
2014-02-03 20:28 ` York Sun
2014-02-03 21:35 ` Scott Wood
2014-02-03 21:36 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE18F3.9000002@freescale.com \
--to=prabhakar@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox