public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness
Date: Tue, 21 Jan 2014 09:34:07 -0800	[thread overview]
Message-ID: <52DEAF8F.1010204@freescale.com> (raw)
In-Reply-To: <1390325356.24905.485.camel@snotra.buserror.net>

On 01/21/2014 09:29 AM, Scott Wood wrote:
> On Tue, 2014-01-21 at 10:14 +0100, Wolfgang Denk wrote:
>> Dear York,
>>
>> In message <F1D691E4-180A-4A2D-BE07-812547D46419@freescale.com> you wrote:
>>>
>>>> On second thought, I also think we should avoid solutions where the
>>>> BE/LE test has to be done for each and every I/O accessor call again
>>>> and again.  We should rather do this just once, and for example set
>>>> function pointers as needed (hoping that this driver will only be
>>>> needed after relocation, so we have writable data segment).
>>>
>>> I like the idea of setting it just once, but I don't see how to
>>> implement it. A pointer is probably not the solution, because we do need
>>> some drivers before relocation.
>>
>> "some drivers before relocation" - how many which are these?

IFC, DDR, I2C (only 32-bit controller is concerned), GUT

>>
>> Also, is it really necessary to make the decision about endianess at
>> runtime?  We don't have multi-board support in U-Boot yet, so when you
>> build an image you know exactly which SoC you are building for, so you
>> should be able to make the selection at compile time?
> 
> It is done at compile time in this patch.
> 

No. It is not necessary to do it at run time. It would be easier to use a switch
to decide at compiling time. It does involve many changes to implement the wrapper.

York

  reply	other threads:[~2014-01-21 17:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18  6:58 [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness Prabhakar Kushwaha
2014-01-18  8:24 ` Wolfgang Denk
2014-01-20 22:51   ` Scott Wood
2014-01-21  5:42     ` Wolfgang Denk
2014-01-21  6:34       ` Wolfgang Denk
2014-01-21  6:49         ` York Sun
2014-01-21  9:14           ` Wolfgang Denk
2014-01-21 17:29             ` Scott Wood
2014-01-21 17:34               ` York Sun [this message]
2014-01-24 17:57                 ` York Sun
2014-01-21  6:51         ` Prabhakar Kushwaha
2014-02-03 20:28 ` York Sun
2014-02-03 21:35   ` Scott Wood
2014-02-03 21:36     ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52DEAF8F.1010204@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox