From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Rini <trini@ti.com>
Date: Tue, 21 Jan 2014 16:23:54 -0500
Subject: [U-Boot] [PATCH 1/5] tools: mkimage: add support for gpimage
 format
In-Reply-To: <20140121193426.D2D8138201D@gemini.denx.de>
References: <1390255810-19486-1-git-send-email-m-karicheri2@ti.com>
	<1390255810-19486-2-git-send-email-m-karicheri2@ti.com>
	<20140120224649.5266D3803D0@gemini.denx.de>
	<3E54258959B69E4282D79E01AB1F32B70466CE4A@DFLE11.ent.ti.com>
	<20140121193426.D2D8138201D@gemini.denx.de>
Message-ID: <52DEE56A.7050103@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/21/2014 02:34 PM, Wolfgang Denk wrote:
> Dear Murali,
> 
> In message
> <3E54258959B69E4282D79E01AB1F32B70466CE4A@DFLE11.ent.ti.com> you
> wrote:
>> 
>>>> +	if (do_swap32) { +		gph_size = gpimage_swap32(gph->size); +
>>>> gph_load_addr = gpimage_swap32(gph->load_addr); +	} else { +
>>>> gph_size = gph->size; +		gph_load_addr = gph->load_addr; +	}
>>> 
>>> I think it should be possible top write this code in such a way
>>> that you can avoid both the if- else and passing the  do_swap32
>>> parameter. It is my impression that the whole endianess
>>> handling needs some refinemant.
>>> 
>>> Actually I cannot see a place where do_swap32=0 is used..
>> 
>> This is done to keep the omapimage usage of this variable.
> 
> Is this actually used?  It appear the omapimage handling would set 
> do_swap32=1 only when imagename == "byteswap" (see
> "tools/omapimage.c"). Is this a practical usecase anywhere?

In omapimage? Yes.  On gpimage?  I doubt it.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS3uVpAAoJENk4IS6UOR1WzoUP/1SFGSUOUV+T9F/2qFTpftNf
Wt/3d+Pel7YFxzswZcj2Tmgdf8dpN6/3VUXByRxvru7MPOXvKLkVgr6m94s0a5lH
T6i/492u5H+BdHVBXfQlSqULMOExWk6CEtRzIydEqrLmS6PehTCcuvDLrPYBeegk
xncOap21YoPzfA8cvFhZ8y+ucVCbS7U/zHhLoNw69pc+AW0aZjTzOgEBdTHagkCX
KV4WxfTAmBnOl+u7Pn38GPU9zfvVre4UDINiVN+/Qr6vru9B5MYAUIdOAb9a9O6x
a00Yoh9xRfW9PbAyguW+EoURX5aIhoLFTTEDJ6HKyvmt4qhw+riG2/GrkXaRYJPD
kifL1wfkQOYHD5E59soJ5XV1GqIfocvEO4aCmdNmizJlXsjlLNgeIklRdv1dA1Dt
f2RaSlip/B1+joLyxthCqG9VfU2PKz3m6+Wy2SxIO1lf2cGbgKFJY6oGi5gGpTCy
+TbpZx+1ltF36zKIFIdKqHc9w9xMc05VYZfSqfOBmGe3NTuR1tRB2FvrBdEYOqIW
LNOLAz0od/mTxG0tiP+BkGNx+ZwYMhck3zZIXdWBOmCigu0RFFG5SSIF0uGoAv/z
Th3y3qhCDJ2YGef+euWJvQwz1oxXb7WdV23p+zmDPSyQUpl0eKDyiMrq0ooo/TZI
pplaUIOfbd5sumSZC4E2
=X3XI
-----END PGP SIGNATURE-----