From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Fri, 24 Jan 2014 10:08:12 -0700
Subject: [U-Boot] [PATCH 2/6] ARM: tegra: rename MASK_BITS_29_28 to
	MASK_BITS_31_28
In-Reply-To: <20140124134446.GA25720@ulmo.nvidia.com>
References: <1390422036-31947-1-git-send-email-swarren@wwwdotorg.org>
	<1390422036-31947-2-git-send-email-swarren@wwwdotorg.org>
	<20140124134446.GA25720@ulmo.nvidia.com>
Message-ID: <52E29DFC.7090104@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/24/2014 06:44 AM, Thierry Reding wrote:
> On Wed, Jan 22, 2014 at 01:20:32PM -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> The only place where the MASK_BITS_* values are used is in
>> adjust_periph_pll(), which interprets the value 4 (old MASK_BITS_29_28,
>> new MASK_BITS_31_28) as being associated with mask OUT_CLK_SOURCE4_MASK,
>> i.e. bits 31:28. Rename the MASK_BITS_ macro to reflect how it's actually
>> implemented.

>>  enum {
>>  	MASK_BITS_31_30	= 2,	/* num of bits used to specify clock source */
>>  	MASK_BITS_31_29,
>> -	MASK_BITS_29_28,
>> +	MASK_BITS_31_28,
>>  };
> 
> If this ever gets cleaned up I think it'd be clearer to explicitly
> define them to the number of bits that they use by turning them into
> #defines.

The specific values are actually removed later in the series. I'll fix
the other issues you found.