[U-Boot] [PATCH V2 08/13] ARM: tegra: add SPL/AVP (arm720t) CPU files for Tegra124

Stephen Warren
2014-01-24T18:29:19Z

On 01/24/2014 08:44 AM, Thierry Reding wrote:
> On Thu, Jan 23, 2014 at 05:42:55PM -0700, Stephen Warren wrote:

>> diff --git a/arch/arm/cpu/arm720t/tegra124/cpu.c b/arch/arm/cpu/arm720t/tegra124/cpu.c
> [...]
>> +static void enable_cpu_power_rail(void)
>> +{
> [...]
>> + /* un-tristate PWR_I2C SCL/SDA, rest of the defaults are correct */
>> + pinmux_tristate_disable(PINGRP_PWR_I2C_SCL);
>> + pinmux_tristate_disable(PINGRP_PWR_I2C_SDA);
>> +
>> + pmic_enable_cpu_vdd();
>
> Should the pinmux changes perhaps be moved to the pmic_enable_cpu_vdd()
> function?

That function is implemented inside the PMIC "driver", so shouldn't know
anything about Tegra pinmux. I guess this special case is required,
since this code is part of the SPL, which doesn't do any of the
board-specific pinmuxing; that is deferred to the main U-Boot which runs
on the main CPU.

> I guess it doesn't really matter since it should be pretty safe to
> assume that all boards will always use the power I2C to talk to the
> PMU?

One would hope so; it's a pretty core part of the Tegra chip architecture.