From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Mon, 27 Jan 2014 08:42:41 +0100
Subject: [U-Boot] [PATCH 2/7] fdt: add "fdt sign" command
In-Reply-To: <20140127065005.3F68238033A@gemini.denx.de>
References: <1390632269-8971-1-git-send-email-hs@denx.de>
	<1390632269-8971-3-git-send-email-hs@denx.de>
	<CAPnjgZ2Yf-mqWS6cGcntCdsyK_Usi9VmB7w+bX7aF6+2mkjiyg@mail.gmail.com>
	<52E5FE93.2030306@denx.de>
	<20140127065005.3F68238033A@gemini.denx.de>
Message-ID: <52E60DF1.3080909@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Wolfgang,

Am 27.01.2014 07:50, schrieb Wolfgang Denk:
> Dear Heiko,
>
> In message<52E5FE93.2030306@denx.de>  you wrote:
>>
>>>> +               cfg_noffset = fit_conf_get_node(working_fdt, NULL);
>>>> +               if (!cfg_noffset)
>>>> +                       return CMD_RET_FAILURE;
>>>
>>> May need to print an error here, since otherwise it won't be clear
>>> what went wrong.
>>
>> Hmm... fit_conf_get_node() prints a dedicated error message if debug is
>                                                                ^^^^^^^^^^^
>> activated... I thought this is enough ... ?
>    ^^^^^^^^^
>
> But in production versions (with debug NOT enabled) the user would
> never know what went wrong?

Good argument, so, add an error message in next patch version.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany