From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 29 Jan 2014 11:38:55 -0700 Subject: [U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed In-Reply-To: <52E8C84A.3010300@suse.de> References: <1390974126-4805-1-git-send-email-swarren@wwwdotorg.org> <52E8C84A.3010300@suse.de> Message-ID: <52E94ABF.8090906@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/29/2014 02:22 AM, Andreas F?rber wrote: > Hi, > > Am 29.01.2014 06:42, schrieb Stephen Warren: >> The entries in config.mk were needed so that U-Boot could be built >> with an old version of the Raspberry Pi Foundation's toolchain. Without >> them, the build would error out with: >> >> ...-ld: error: .../libgcc.a(_bswapsi2.o) uses VFP register arguments, >> u-boot does not >> >> However, none of the 3 toolchains in the latest version of their >> tools.git, nor the Ubuntu/Linaro ARM compilers in at least Ubuntu Quantal >> or Saucy, need these options set in order to compile a working U-Boot. >> Hence, remove the options for simplicity. >> >> Reported-by: Tom Rini >> Signed-off-by: Stephen Warren >> --- >> arch/arm/cpu/arm1176/bcm2835/config.mk | 19 ------------------- >> 1 file changed, 19 deletions(-) >> delete mode 100644 arch/arm/cpu/arm1176/bcm2835/config.mk > > No objection against the patch, but why was arch/arm/config.mk using > -msoft-float in the first place? It wasn't. It was filtering -msoft-float out of the compiler flags, which then left the ABI up to the toolchain default, which was hardfp for one of the Raspberry Pi Foundation's toolchains - the same one that caused the error messages quoted above unless -msoft-float was removed from the compiler options.