[U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed

[Tom Rini <trini@ti.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/29/2014 02:41 PM, Andreas F?rber wrote:
> Am 29.01.2014 19:38, schrieb Stephen Warren:
>> On 01/29/2014 02:22 AM, Andreas F?rber wrote:
>>> Am 29.01.2014 06:42, schrieb Stephen Warren:
>>>> The entries in config.mk were needed so that U-Boot could be
>>>> built with an old version of the Raspberry Pi Foundation's
>>>> toolchain. Without them, the build would error out with:
>>>> 
>>>> ...-ld: error: .../libgcc.a(_bswapsi2.o) uses VFP register
>>>> arguments, u-boot does not
>>>> 
>>>> However, none of the 3 toolchains in the latest version of
>>>> their tools.git, nor the Ubuntu/Linaro ARM compilers in at
>>>> least Ubuntu Quantal or Saucy, need these options set in
>>>> order to compile a working U-Boot. Hence, remove the options
>>>> for simplicity.
>>>> 
>>>> Reported-by: Tom Rini <trini@ti.com> Signed-off-by: Stephen
>>>> Warren <swarren@wwwdotorg.org> --- 
>>>> arch/arm/cpu/arm1176/bcm2835/config.mk | 19
>>>> ------------------- 1 file changed, 19 deletions(-) delete
>>>> mode 100644 arch/arm/cpu/arm1176/bcm2835/config.mk
>>> 
>>> No objection against the patch, but why was arch/arm/config.mk
>>> using -msoft-float in the first place?
>> 
>> It wasn't. It was filtering -msoft-float out of the compiler
>> flags, which then left the ABI up to the toolchain default, which
>> was hardfp for one of the Raspberry Pi Foundation's toolchains -
>> the same one that caused the error messages quoted above unless
>> -msoft-float was removed from the compiler options.
> 
> You seem to have misread my question, it was not about
> bcm2835/config.mk but about arm/config.mk, which bcm2835 was
> filtering.

No, I know what you said.

> I didn't quite get Tom's response about U-Boot being soft-float. It
> is what I compile it to be, no? If I compile it with an hardfp
> toolchain such as openSUSE's, without -msoft-float it is going to
> be hardfp IIUC. softfp is for compatibility with non-VFP hardware I
> thought, but U-Boot is clearly built with a per-board config, so
> it's not portable anyway.

This isn't quite correct.  U-Boot is like the kernel.  We say how
we're built and like the kernel, we are soft float (and unless the
board says we need it, we aren't thumb/thumb2 either).  That's why
arch/arm/config.mk (like arch/arm/Makefile in the kernel) enforces
- -msoft-float.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS6Vq5AAoJENk4IS6UOR1WMCYQAIn6ki/N2ts1S27/PHuUqJRM
ogEvhpejaYv35GxKMqMvlz264r/8WCzXJHhATpjST3gP0NTgD5ATHJMIW0gvjMEi
F855bSr+lRo1bAbzdrn14bWprqCCSnKGQp3f5H4V1pt8Zck3g+lZay+9d+hwW/8k
SXylTjqhsCqseq5D+FdUbcuVZmeqUBbX3iM9kfPD9IvTaYDvEFDCj5JcFpQnM62h
Eo/i0id2hV9dTaeC2UPSBKZ0xyNajGZAMTrZTeSPNfHLnAjPyG1UVOl29V3LHME6
qwBmZwbtWhSJARaNW8HwT/6ngewetjyJdjb9hi4HGlBJDJtfJIH/XanBZOVaSW9B
jwmjpxF7n3drqODTKWb5GXOUkUbojPfKtWVvDsLKRuZgkpxUnTM208EL7aebQ1zs
N84FkiUsbcIBDwkLBtTLl8spE9ZFNk/LgGUnTiBe0oF3+GAxqC8rx8rz9kn8D5Xa
668k8uT0PiXCXtPM2PVQN7HTCIuUcaBRV4FOjJy6UNVS0QV96MY5Gnou44I0cmZH
OY5r3g4tekWpUOL1904Rur2KbhP01nhw4PPKZBU6q2Kk6zlA1BWNVEXN3lT+WY0g
wHtvD2vhS0MiBNpNBIhgeKghW3B/2SMUDbP1BEI1kq8pccLObA9kMluTjnaw7TPt
NOZs19lCtOsJKb3Ot5Mu
=Lob9
-----END PGP SIGNATURE-----