From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Wed, 29 Jan 2014 18:18:46 -0800
Subject: [U-Boot] [PATCH] powerpc/t104xrdb: Add basic ethernet support
In-Reply-To: <1390891476-30453-1-git-send-email-Priyanka.Jain@freescale.com>
References: <1390891476-30453-1-git-send-email-Priyanka.Jain@freescale.com>
Message-ID: <52E9B686.8070602@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/27/2014 10:44 PM, Priyanka Jain wrote:
> This covers only non-L2 switch ethernet interfaces i.e.
> RGMII and SGMII interface for both 
> -T1040RDB
> -T1042RDB_PI
> 
> T1040RDB is configured as serdes protocol 0x66 which can
> support following interfaces
> -2 RGMIIS on DTSEC4, DTSEC5
> -1 SGMII on DTSEC3
> 
> T1042RDB_PI is configured as serdes protocol 0x06 which can
> support following interfaces
> -2 RGMIIS on DTSEC4, DTSEC5
> 
> 
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> ---
>  board/freescale/t104xrdb/Makefile |    1 +
>  board/freescale/t104xrdb/eth.c    |   72 +++++++++++++++++++++++++++++++++++++
>  include/configs/T1040RDB.h        |    9 ++---
>  include/configs/T1042RDB_PI.h     |    5 ++-
>  4 files changed, 81 insertions(+), 6 deletions(-)
>  create mode 100644 board/freescale/t104xrdb/eth.c
> 
> diff --git a/board/freescale/t104xrdb/Makefile b/board/freescale/t104xrdb/Makefile
> index 76c0c94..e51fb7a 100644
> --- a/board/freescale/t104xrdb/Makefile
> +++ b/board/freescale/t104xrdb/Makefile
> @@ -7,6 +7,7 @@
>  
>  obj-y	+= t104xrdb.o
>  obj-y	+= ddr.o
> +obj-y	+= eth.o
>  obj-$(CONFIG_PCI)	+= pci.o
>  obj-y	+= law.o
>  obj-y	+= tlb.o
> diff --git a/board/freescale/t104xrdb/eth.c b/board/freescale/t104xrdb/eth.c
> new file mode 100644
> index 0000000..448434b
> --- /dev/null
> +++ b/board/freescale/t104xrdb/eth.c
> @@ -0,0 +1,72 @@
> +/*
> + * Copyright 2014 Freescale Semiconductor, Inc.
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <netdev.h>
> +#include <asm/immap_85xx.h>
> +#include <fm_eth.h>
> +#include <fsl_mdio.h>
> +#include <malloc.h>
> +#include <asm/fsl_dtsec.h>
> +
> +#include "../common/fman.h"
> +
> +int board_eth_init(bd_t *bis)
> +{
> +#ifdef CONFIG_FMAN_ENET
> +	struct memac_mdio_info memac_mdio_info;
> +	unsigned int i;
> +	int phy_addr;
> +	printf("Initializing Fman\n");
> +
> +	memac_mdio_info.regs =
> +		(struct memac_mdio_controller *)CONFIG_SYS_FM1_DTSEC_MDIO_ADDR;
> +	memac_mdio_info.name = DEFAULT_FM_MDIO_NAME;
> +
> +	/* Register the real 1G MDIO bus */
> +	fm_memac_mdio_init(bis, &memac_mdio_info);
> +
> +	/*
> +	 * Program on board RGMII, SGMII PHY addresses.
> +	 */
> +	for (i = FM1_DTSEC1; i < FM1_DTSEC1 + CONFIG_SYS_NUM_FM1_DTSEC; i++) {
> +		int idx = i - FM1_DTSEC1;
> +
> +		switch (fm_info_get_enet_if(i)) {
> +#ifdef CONFIG_T1040RDB
> +		case PHY_INTERFACE_MODE_SGMII:
> +			/* T1040RDB only supports SGMII on DTSEC3 */
> +			fm_info_set_phy_address(FM1_DTSEC3,
> +						CONFIG_SYS_SGMII1_PHY_ADDR);
> +#endif
> +		case PHY_INTERFACE_MODE_RGMII:
> +			if (FM1_DTSEC4 == i)
> +				phy_addr = CONFIG_SYS_RGMII1_PHY_ADDR;
> +			if (FM1_DTSEC5 == i)
> +				phy_addr = CONFIG_SYS_RGMII2_PHY_ADDR;
> +			fm_info_set_phy_address(i, phy_addr);

Compiling warning here

warning: 'phy_addr' may be used uninitialized in this function

York