public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support
Date: Thu, 30 Jan 2014 06:20:59 +0100	[thread overview]
Message-ID: <52E9E13B.7060608@denx.de> (raw)
In-Reply-To: <1390405024.10878.2.camel@clsee-VirtualBox>

Hello Chin,

Am 22.01.2014 16:37, schrieb Chin Liang See:
> Thanks Alexey.
>
> Hi Heiko,
>
> I believe this patch should be good for apply. Would need your help
> then. :) Thanks
>
> Chin Liang
>
>
> On Wed, 2014-01-15 at 15:51 +0000, Alexey Brodkin wrote:
>> On Wed, 2014-01-15 at 09:45 -0600, Chin Liang See wrote:
>>> Changes for v2
>>> - Removed the function check_params()
>>
>> Ok, so you decided to not add "assert" check instead.
>> I think it's ok - it's not a requirement. Others don't do it as well so
>> let's leave it as it is.
>>
>> Acked-by: Alexey Brodkin<abrodkin@synopsys.com>
>>
>> Regards,
>> Alexey

Your patch apply not clean to current head f889cc81c1572f4af0be950fd49bb6b67bc580fb
also checkpatch drops one warning:

CHECK: Alignment should match open parenthesis
#82: FILE: drivers/i2c/designware_i2c.c:210:
+               writel((addr >> (alen * 8)) & 0xff,
+                       &i2c_regs_p->ic_cmd_data);

total: 0 errors, 0 warnings, 1 checks, 64 lines checked

Could you please fix this, thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-01-30  5:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 15:45 [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support Chin Liang See
2014-01-15 15:51 ` Alexey Brodkin
2014-01-22 15:37   ` Chin Liang See
2014-01-30  5:20     ` Heiko Schocher [this message]
2014-02-04 17:51       ` Chin Liang See

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E9E13B.7060608@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox