From mboxrd@z Thu Jan  1 00:00:00 1970
From: Darwin Rambo <drambo@broadcom.com>
Date: Thu, 30 Jan 2014 15:09:23 -0800
Subject: [U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common
 architecture code
In-Reply-To: <20140129223218.GW3277@bill-the-cat>
References: <1390848810-7227-1-git-send-email-drambo@broadcom.com>
	<1390848810-7227-2-git-send-email-drambo@broadcom.com>
	<20140129223218.GW3277@bill-the-cat>
Message-ID: <52EADBA3.7020803@broadcom.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On 14-01-29 02:32 PM, Tom Rini wrote:
> On Mon, Jan 27, 2014 at 10:53:25AM -0800, Darwin Rambo wrote:
> 
>> The Kona architecture is present on a number of Broadcom mobile SoCs
>> including the bcm281xx family of chips.
> [snip]
>> +int __weak clk_sdio_enable(void *base, u32 rate, u32 *actual_ratep)
>> +{
>> +	return 0;
>> +}
>> +int __weak clk_bsc_enable(void *base, u32 rate, u32 *actual_ratep)
>> +{
>> +	return 0;
>> +}
> 
> Blank lines between functions please.
OK
> 
>> diff --git a/arch/arm/cpu/armv7/kona-common/lowlevel_init.S b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
>> new file mode 100644
>> index 0000000..a03afcc
>> --- /dev/null
>> +++ b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
>> @@ -0,0 +1,15 @@
>> +/*****************************************************************************
>> +*
>> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
>> +*
>> +* SPDX-License-Identifier:      GPL-2.0+
>> +*
>> +*****************************************************************************/
>> +
>> +//#include <asm-offsets.h>
>> +//#include <config.h>
>> +//#include <linux/linkage.h>
>> +
>> +.globl lowlevel_init
>> +lowlevel_init:
>> +	mov	pc, lr
> 
> (a) no commented out include lines
OK
> (b) This is empty, which seems wrong.  I strongly suspect you want to
> make use of arch/arm/cpu/armv7/lowlevel_init.S and have an s_init
> function, ala omap*/tegra/rmobile/etc.
Will check this out. Thanks.
> 
>> diff --git a/arch/arm/cpu/armv7/kona-common/proc.c b/arch/arm/cpu/armv7/kona-common/proc.c
>> new file mode 100644
>> index 0000000..92fb39b
>> --- /dev/null
>> +++ b/arch/arm/cpu/armv7/kona-common/proc.c
>> @@ -0,0 +1,20 @@
>> +/*****************************************************************************
>> +*
>> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
>> +*
>> +* SPDX-License-Identifier:      GPL-2.0+
>> +*
>> +*****************************************************************************/
>> +
>> +#include <common.h>
>> +#include <asm/io.h>
>> +#include <asm/kona-common/misc.h>
>> +#include <asm/armv7.h>
>> +
>> +void do_proc_wfe(int forever)
>> +{
>> +	do {
>> +		asm volatile ("wfe	@ wait for event\n");
>> +		/*printf("wake up from wfe\n"); */
> 
> No commented out printf, thanks.
> 
OK