From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Mon, 03 Feb 2014 17:18:24 +0900
Subject: [U-Boot] [PATCH V2 1/8] arm:exynos: add cpu revision
In-Reply-To: <20140123102832.ABC0A3801AF@gemini.denx.de>
References: <1389686350-6697-1-git-send-email-p.wilczek@samsung.com>
	<1390402477-24340-1-git-send-email-p.wilczek@samsung.com>
	<1390402477-24340-2-git-send-email-p.wilczek@samsung.com>
	<20140123102832.ABC0A3801AF@gemini.denx.de>
Message-ID: <52EF50D0.8040504@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

On 23/01/14 19:28, Wolfgang Denk wrote:
> Dear Piotr Wilczek,
> 
> In message <1390402477-24340-2-git-send-email-p.wilczek@samsung.com> you wrote:
>> This patch enables to read cpu revision on Exynos CPU.
> 
> Sorry,  you really need to refactor your patches.
> 
> In this commit you add references to "s5p_cpu_id":
> 
>> @@ -196,10 +198,12 @@ static inline void s5p_set_cpu_id(void)
>>  	case 0x210:
>>  		/* Exynos4210 EVT1 */
>>  		s5p_cpu_id = 0x4210;
>> +		s5p_cpu_rev = cpu_rev;
>>  		break;
>>  	case 0x412:
>>  		/* Exynos4412 */
>>  		s5p_cpu_id = 0x4412;
>> +		s5p_cpu_rev = cpu_rev;
>>  		break;
>>  	case 0x520:
>>  		/* Exynos5250 */
> 
> But this variable does not exist anywhere.  It is only added in the
> next patch.  Adding this patch causes build breakage, i. e. your patch
> series is not bisectable.

s5p_cpu_id and s5p_cpu_rev exist on "arch/arm/cpu/armv7/s5p-common/cpu_info.c".
This patch looks fine to me.

Thanks,
Minkyu Kang.