public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] exynos: pinmux: remove unnecessary routine
Date: Mon, 03 Feb 2014 20:38:17 +0900	[thread overview]
Message-ID: <52EF7FA9.5070106@samsung.com> (raw)
In-Reply-To: <52E8B601.8070502@samsung.com>

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 01/29/2014 05:04 PM, Minkyu Kang wrote:
> Because of the list of peripherals is not sequential,
> such a routine does not check for valid correctly.
> Error check will be done when call the exynos_pinmux_config function.
> 
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/pinmux.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
> index 904177a..645c497 100644
> --- a/arch/arm/cpu/armv7/exynos/pinmux.c
> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> @@ -751,12 +751,7 @@ static int exynos5_pinmux_decode_periph_id(const void *blob, int node)
>  	if (err)
>  		return PERIPH_ID_NONE;
>  
> -	/* check for invalid peripheral id */
> -	if ((PERIPH_ID_SDMMC4 > cell[1]) || (cell[1] < PERIPH_ID_UART0))
> -		return cell[1];
> -
> -	debug(" invalid peripheral id\n");
> -	return PERIPH_ID_NONE;
> +	return cell[1];
>  }
>  
>  int pinmux_decode_periph_id(const void *blob, int node)
> 

  parent reply	other threads:[~2014-02-03 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29  8:04 [U-Boot] [PATCH 3/3] exynos: pinmux: remove unnecessary routine Minkyu Kang
2014-01-29  9:01 ` Rajeshwari Birje
2014-02-03  7:23   ` Minkyu Kang
2014-02-04  9:12     ` Rajeshwari Birje
2014-02-03 11:38 ` Jaehoon Chung [this message]
2014-02-05  7:25 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EF7FA9.5070106@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox