From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Mon, 03 Feb 2014 20:38:17 +0900 Subject: [U-Boot] [PATCH 3/3] exynos: pinmux: remove unnecessary routine In-Reply-To: <52E8B601.8070502@samsung.com> References: <52E8B601.8070502@samsung.com> Message-ID: <52EF7FA9.5070106@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Acked-by: Jaehoon Chung On 01/29/2014 05:04 PM, Minkyu Kang wrote: > Because of the list of peripherals is not sequential, > such a routine does not check for valid correctly. > Error check will be done when call the exynos_pinmux_config function. > > Signed-off-by: Minkyu Kang > --- > arch/arm/cpu/armv7/exynos/pinmux.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c > index 904177a..645c497 100644 > --- a/arch/arm/cpu/armv7/exynos/pinmux.c > +++ b/arch/arm/cpu/armv7/exynos/pinmux.c > @@ -751,12 +751,7 @@ static int exynos5_pinmux_decode_periph_id(const void *blob, int node) > if (err) > return PERIPH_ID_NONE; > > - /* check for invalid peripheral id */ > - if ((PERIPH_ID_SDMMC4 > cell[1]) || (cell[1] < PERIPH_ID_UART0)) > - return cell[1]; > - > - debug(" invalid peripheral id\n"); > - return PERIPH_ID_NONE; > + return cell[1]; > } > > int pinmux_decode_periph_id(const void *blob, int node) >