public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: mx6: Implement reset callback
Date: Mon, 03 Feb 2014 21:12:37 +0100	[thread overview]
Message-ID: <52EFF835.4000102@denx.de> (raw)
In-Reply-To: <201402031917.26507.marex@denx.de>

Hi Marek,

On 03/02/2014 19:17, Marek Vasut wrote:
>
> Well ... SL and N6X both. For all I care, we can have #define
> MX6_PCIE_RESET_GPIO and if that's not defined, puke out this warning. And
> ultimatelly let this function be overriden anyway in case people used some GPIO
> expander or whatnot. So the change to this would be:
>
> __weak int imx6_pcie_toggle_reset(void)
> {
> #ifdef CONFIG_MX6_PCIE_RESET_GPIO
>   gpio_set...
>   mdelay();
>   gpio_set...
>   mdelay();
> #else
>   puts("Oh yeah, broken design :-(\n");
> #endif
> }
>
> This should effectivelly give you all the flexibility, what do you say?

Right. Go on !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2014-02-03 20:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24 15:25 [U-Boot] [PATCH] pci: mx6: Implement reset callback Marek Vasut
2014-01-28 15:06 ` Stefano Babic
2014-01-28 19:32   ` Marek Vasut
2014-02-03 11:56     ` Stefano Babic
2014-02-03 18:17       ` Marek Vasut
2014-02-03 18:40         ` Eric Nelson
2014-02-03 19:33           ` Marek Vasut
2014-02-03 19:57             ` Eric Nelson
2014-02-03 20:16               ` Marek Vasut
2014-02-03 20:54                 ` Eric Nelson
2014-02-03 23:34                   ` Marek Vasut
2014-02-04  0:57                     ` Eric Nelson
2014-02-04 11:25                       ` Marek Vasut
2014-02-03 20:12         ` Stefano Babic [this message]
2014-01-31  5:33 ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52EFF835.4000102@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox