From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 03 Feb 2014 21:12:37 +0100 Subject: [U-Boot] [PATCH] pci: mx6: Implement reset callback In-Reply-To: <201402031917.26507.marex@denx.de> References: <1390577140-7402-1-git-send-email-marex@denx.de> <201401282032.17617.marex@denx.de> <52EF83D4.7010708@denx.de> <201402031917.26507.marex@denx.de> Message-ID: <52EFF835.4000102@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On 03/02/2014 19:17, Marek Vasut wrote: > > Well ... SL and N6X both. For all I care, we can have #define > MX6_PCIE_RESET_GPIO and if that's not defined, puke out this warning. And > ultimatelly let this function be overriden anyway in case people used some GPIO > expander or whatnot. So the change to this would be: > > __weak int imx6_pcie_toggle_reset(void) > { > #ifdef CONFIG_MX6_PCIE_RESET_GPIO > gpio_set... > mdelay(); > gpio_set... > mdelay(); > #else > puts("Oh yeah, broken design :-(\n"); > #endif > } > > This should effectivelly give you all the flexibility, what do you say? Right. Go on ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================