public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] ARM: tegra: fix NV_PA_CSITE_BASE for Tegra124
Date: Mon, 03 Feb 2014 14:25:10 -0700	[thread overview]
Message-ID: <52F00936.7060609@wwwdotorg.org> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F37F4717D55@HQMAIL04.nvidia.com>

On 02/03/2014 02:18 PM, Tom Warren wrote:
> Nice catch, fortunately I don't see this base addr used anywhere (yet) in T124.

It's used to define CSITE_CPU_DBG*_LAR, and those are used in code.

(The internal Tegra simulator I'm running complains about the incorrect
register accesses when booting U-boot)

> 
>> -----Original Message-----
>> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
>> Sent: Monday, February 03, 2014 2:03 PM
>> To: u-boot at lists.denx.de; Simon Glass; Tom Warren; Stephen Warren
>> Subject: [PATCH 3/4] ARM: tegra: fix NV_PA_CSITE_BASE for Tegra124
>>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Tegra124 moved the CSITE block's base address. Fix U-Boot to use the correct
>> address.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>>  arch/arm/include/asm/arch-tegra/tegra.h | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-tegra/tegra.h
>> b/arch/arm/include/asm/arch-tegra/tegra.h
>> index 5fe19ae1ac13..d63af0e5fd9c 100644
>> --- a/arch/arm/include/asm/arch-tegra/tegra.h
>> +++ b/arch/arm/include/asm/arch-tegra/tegra.h
>> @@ -34,7 +34,12 @@
>>  #define NV_PA_PMC_BASE		(NV_PA_APB_MISC_BASE + 0xE400)
>>  #define NV_PA_EMC_BASE		(NV_PA_APB_MISC_BASE + 0xF400)
>>  #define NV_PA_FUSE_BASE		(NV_PA_APB_MISC_BASE + 0xF800)
>> +#if defined(CONFIG_TEGRA20) || defined(CONFIG_TEGRA30) || \
>> +	defined(CONFIG_TEGRA114)
>>  #define NV_PA_CSITE_BASE	0x70040000
>> +#else
>> +#define NV_PA_CSITE_BASE	0x70800000
>> +#endif
>>  #define TEGRA_USB_ADDR_MASK	0xFFFFC000
>>
>>  #define NV_PA_SDRC_CS0		NV_PA_SDRAM_BASE
>> --
>> 1.8.1.5
> --
> nvpublic
> 

  reply	other threads:[~2014-02-03 21:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 21:03 [U-Boot] [PATCH 1/4] ARM: tegra: move CONFIG_TEGRAnn Stephen Warren
2014-02-03 21:03 ` [U-Boot] [PATCH 2/4] ARM: tegra: fix pmc_pwrgate_timer_mult register definition Stephen Warren
2014-02-03 21:03 ` [U-Boot] [PATCH 3/4] ARM: tegra: fix NV_PA_CSITE_BASE for Tegra124 Stephen Warren
2014-02-03 21:18   ` Tom Warren
2014-02-03 21:25     ` Stephen Warren [this message]
2014-02-03 21:03 ` [U-Boot] [PATCH 4/4] ARM: tegra: simplify halt_avp() Stephen Warren
2014-02-27 17:19   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F00936.7060609@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox