* [U-Boot] [PATCH] mmc: set rca to 1 for MMC cards
@ 2014-01-30 23:11 Stephen Warren
2014-02-04 1:04 ` Jaehoon Chung
2014-02-07 15:32 ` Pantelis Antoniou
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Warren @ 2014-01-30 23:11 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
U-Boot currently sets MMC cards' RCA register to 0. This value is
reserved according to the specification. Use a value of 1 instead, just
like the Linux kernel.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
drivers/mmc/mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index c6a1c23fbf1c..7efc2bedbe11 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
mmc->ocr = cmd.response[0];
mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
- mmc->rca = 0;
+ mmc->rca = 1;
return 0;
}
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: set rca to 1 for MMC cards
2014-01-30 23:11 [U-Boot] [PATCH] mmc: set rca to 1 for MMC cards Stephen Warren
@ 2014-02-04 1:04 ` Jaehoon Chung
2014-02-07 15:32 ` Pantelis Antoniou
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2014-02-04 1:04 UTC (permalink / raw)
To: u-boot
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 01/31/2014 08:11 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> U-Boot currently sets MMC cards' RCA register to 0. This value is
> reserved according to the specification. Use a value of 1 instead, just
> like the Linux kernel.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c6a1c23fbf1c..7efc2bedbe11 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
> mmc->ocr = cmd.response[0];
>
> mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
> - mmc->rca = 0;
> + mmc->rca = 1;
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: set rca to 1 for MMC cards
2014-01-30 23:11 [U-Boot] [PATCH] mmc: set rca to 1 for MMC cards Stephen Warren
2014-02-04 1:04 ` Jaehoon Chung
@ 2014-02-07 15:32 ` Pantelis Antoniou
1 sibling, 0 replies; 3+ messages in thread
From: Pantelis Antoniou @ 2014-02-07 15:32 UTC (permalink / raw)
To: u-boot
Looks good.
On Jan 31, 2014, at 1:11 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> U-Boot currently sets MMC cards' RCA register to 0. This value is
> reserved according to the specification. Use a value of 1 instead, just
> like the Linux kernel.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index c6a1c23fbf1c..7efc2bedbe11 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
> mmc->ocr = cmd.response[0];
>
> mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
> - mmc->rca = 0;
> + mmc->rca = 1;
>
> return 0;
> }
> --
> 1.8.1.5
>
Applied, Thanks.
Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-07 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 23:11 [U-Boot] [PATCH] mmc: set rca to 1 for MMC cards Stephen Warren
2014-02-04 1:04 ` Jaehoon Chung
2014-02-07 15:32 ` Pantelis Antoniou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox