From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] U-Boot DWC2 unused variables
Date: Mon, 03 Feb 2014 23:34:04 -0700 [thread overview]
Message-ID: <52F089DC.3000800@wwwdotorg.org> (raw)
Oleksandr,
Thanks for the quick response on the s-o-b lines. Another question: The
compiler is complaining about hprt0 being written but then not used in
the functions below. I assume the second parameter passed to
dwc_write_reg32() should be hprt0.d32 rather than val?
> void dwc_otg_set_prtpower(dwc_otg_core_if_t * core_if, uint32_t val)
> {
> hprt0_data_t hprt0;
> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
> hprt0.b.prtpwr = val;
> dwc_write_reg32(core_if->host_if->hprt0, val);
> }
> void dwc_otg_set_prtsuspend(dwc_otg_core_if_t * core_if, uint32_t val)
> {
> hprt0_data_t hprt0;
> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
> hprt0.b.prtsusp = val;
> dwc_write_reg32(core_if->host_if->hprt0, val);
> }
>
> void dwc_otg_set_prtresume(dwc_otg_core_if_t * core_if, uint32_t val)
> {
> hprt0_data_t hprt0;
> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
> hprt0.b.prtres = val;
> dwc_write_reg32(core_if->host_if->hprt0, val);
> }
next reply other threads:[~2014-02-04 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 6:34 Stephen Warren [this message]
2014-02-10 2:57 ` [U-Boot] U-Boot DWC2 unused variables Oleksandr Tymoshenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F089DC.3000800@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox