* [U-Boot] U-Boot DWC2 unused variables
@ 2014-02-04 6:34 Stephen Warren
2014-02-10 2:57 ` Oleksandr Tymoshenko
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2014-02-04 6:34 UTC (permalink / raw)
To: u-boot
Oleksandr,
Thanks for the quick response on the s-o-b lines. Another question: The
compiler is complaining about hprt0 being written but then not used in
the functions below. I assume the second parameter passed to
dwc_write_reg32() should be hprt0.d32 rather than val?
> void dwc_otg_set_prtpower(dwc_otg_core_if_t * core_if, uint32_t val)
> {
> hprt0_data_t hprt0;
> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
> hprt0.b.prtpwr = val;
> dwc_write_reg32(core_if->host_if->hprt0, val);
> }
> void dwc_otg_set_prtsuspend(dwc_otg_core_if_t * core_if, uint32_t val)
> {
> hprt0_data_t hprt0;
> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
> hprt0.b.prtsusp = val;
> dwc_write_reg32(core_if->host_if->hprt0, val);
> }
>
> void dwc_otg_set_prtresume(dwc_otg_core_if_t * core_if, uint32_t val)
> {
> hprt0_data_t hprt0;
> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
> hprt0.b.prtres = val;
> dwc_write_reg32(core_if->host_if->hprt0, val);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] U-Boot DWC2 unused variables
2014-02-04 6:34 [U-Boot] U-Boot DWC2 unused variables Stephen Warren
@ 2014-02-10 2:57 ` Oleksandr Tymoshenko
0 siblings, 0 replies; 2+ messages in thread
From: Oleksandr Tymoshenko @ 2014-02-10 2:57 UTC (permalink / raw)
To: u-boot
On 2014-02-03, at 10:34 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> Oleksandr,
>
> Thanks for the quick response on the s-o-b lines. Another question: The
> compiler is complaining about hprt0 being written but then not used in
> the functions below. I assume the second parameter passed to
> dwc_write_reg32() should be hprt0.d32 rather than val?
Yes, I think you're right. My mistake.
>
>> void dwc_otg_set_prtpower(dwc_otg_core_if_t * core_if, uint32_t val)
>> {
>> hprt0_data_t hprt0;
>> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
>> hprt0.b.prtpwr = val;
>> dwc_write_reg32(core_if->host_if->hprt0, val);
>> }
>
>> void dwc_otg_set_prtsuspend(dwc_otg_core_if_t * core_if, uint32_t val)
>> {
>> hprt0_data_t hprt0;
>> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
>> hprt0.b.prtsusp = val;
>> dwc_write_reg32(core_if->host_if->hprt0, val);
>> }
>>
>> void dwc_otg_set_prtresume(dwc_otg_core_if_t * core_if, uint32_t val)
>> {
>> hprt0_data_t hprt0;
>> hprt0.d32 = dwc_read_reg32(core_if->host_if->hprt0);
>> hprt0.b.prtres = val;
>> dwc_write_reg32(core_if->host_if->hprt0, val);
>> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-10 2:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 6:34 [U-Boot] U-Boot DWC2 unused variables Stephen Warren
2014-02-10 2:57 ` Oleksandr Tymoshenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox