From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zynq: Fix elf header generation
Date: Wed, 05 Feb 2014 08:07:32 +0100 [thread overview]
Message-ID: <52F1E334.7050103@monstr.eu> (raw)
In-Reply-To: <20140204203507.GD7049@bill-the-cat>
On 02/04/2014 09:35 PM, Tom Rini wrote:
> On Tue, Feb 04, 2014 at 04:59:45PM +0100, Michal Simek wrote:
>
>> This patch is here because of:
>> "arm: keep all sections in ELF file"
>> (sha1: 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7)
>>
>> Our tools expect to have elf with only LOAD header.
>> Without this fix also PHDR, INTERP and DYNAMIC headers
>> are available in ELF.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> [snip]
>
> Two things..
>
>> + /*
>> + * Deprecated: this MMU section is used by pxa at present but
>> + * should not be used by new boards/CPUs.
>> + */
>> + . = ALIGN(4096);
>> + .mmutable : {
>> + *(.mmutable)
>> + }
>
> You don't need this do you? If not, drop it..
I don't need it.
>
> [snip]
>> + /DISCARD/ : { *(.dynsym) }
>> + /DISCARD/ : { *(.dynbss*) }
>> + /DISCARD/ : { *(.dynstr*) }
>> + /DISCARD/ : { *(.dynamic*) }
>> + /DISCARD/ : { *(.plt*) }
>> + /DISCARD/ : { *(.interp*) }
>> + /DISCARD/ : { *(.gnu*) }
>> + /DISCARD/ : { *(.ARM.exidx*) }
>> + /DISCARD/ : { *(.gnu.linkonce.armexidx.*) }
>
> Here is the difference between your linker script and the main ARM one.
> Please add a comment block that explains that you need to discard more
> sections because the user is expected to pass this image on to tools
> that require them to be dropped so it's clear why there is this delta
> between the scripts. Thanks!
Fixed in v2.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140205/cfaaa811/attachment.pgp>
next prev parent reply other threads:[~2014-02-05 7:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 15:59 [U-Boot] [PATCH] zynq: Fix elf header generation Michal Simek
2014-02-04 20:35 ` Tom Rini
2014-02-05 7:07 ` Michal Simek [this message]
2014-02-05 3:00 ` Masahiro Yamada
2014-02-05 7:06 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F1E334.7050103@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox