From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Wed, 05 Feb 2014 08:07:32 +0100 Subject: [U-Boot] [PATCH] zynq: Fix elf header generation In-Reply-To: <20140204203507.GD7049@bill-the-cat> References: <487a4ee4eadcd962017c88958709ea5a8f5b8089.1391529572.git.michal.simek@xilinx.com> <20140204203507.GD7049@bill-the-cat> Message-ID: <52F1E334.7050103@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/04/2014 09:35 PM, Tom Rini wrote: > On Tue, Feb 04, 2014 at 04:59:45PM +0100, Michal Simek wrote: > >> This patch is here because of: >> "arm: keep all sections in ELF file" >> (sha1: 47ed5dd031d7d2c587e6afd386e79ccec1a1b7f7) >> >> Our tools expect to have elf with only LOAD header. >> Without this fix also PHDR, INTERP and DYNAMIC headers >> are available in ELF. >> >> Signed-off-by: Michal Simek > [snip] > > Two things.. > >> + /* >> + * Deprecated: this MMU section is used by pxa at present but >> + * should not be used by new boards/CPUs. >> + */ >> + . = ALIGN(4096); >> + .mmutable : { >> + *(.mmutable) >> + } > > You don't need this do you? If not, drop it.. I don't need it. > > [snip] >> + /DISCARD/ : { *(.dynsym) } >> + /DISCARD/ : { *(.dynbss*) } >> + /DISCARD/ : { *(.dynstr*) } >> + /DISCARD/ : { *(.dynamic*) } >> + /DISCARD/ : { *(.plt*) } >> + /DISCARD/ : { *(.interp*) } >> + /DISCARD/ : { *(.gnu*) } >> + /DISCARD/ : { *(.ARM.exidx*) } >> + /DISCARD/ : { *(.gnu.linkonce.armexidx.*) } > > Here is the difference between your linker script and the main ARM one. > Please add a comment block that explains that you need to discard more > sections because the user is expected to pass this image on to tools > that require them to be dropped so it's clear why there is this delta > between the scripts. Thanks! Fixed in v2. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: