From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 05 Feb 2014 09:13:57 -0700
Subject: [U-Boot] [PATCH V3 2/3] ARM: tegra: rework boot scripts
In-Reply-To: <52F20155.4040808@suse.de>
References: <1391554782-7444-1-git-send-email-swarren@wwwdotorg.org>
	<1391554782-7444-2-git-send-email-swarren@wwwdotorg.org>
	<52F20155.4040808@suse.de>
Message-ID: <52F26345.5000709@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/05/2014 02:16 AM, Andreas F?rber wrote:
> Am 04.02.2014 23:59, schrieb Stephen Warren:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Update the common Tegra boot scripts in the default environment to
>>
>> a) Make use of the new "exists" shell command to avoid some error
>>    messges.
>>
>> b) Allow booting using the sysboot command and extlinux.conf. This
>>    allows easy creation of boot menus, and provides a simple interface
>>    for distros to parameterize/configure the boot process.

>> diff --git a/include/configs/tegra-common-post.h b/include/configs/tegra-common-post.h

>>  	"script_boot="                                                    \
>> -		"if load ${devtype} ${devnum}:${rootpart} "               \
>> -				"${scriptaddr} ${prefix}${script}; then " \
>> -			"echo ${script} found! Executing ...;"            \
>> -			"source ${scriptaddr};"                           \
>> -		"fi;\0"                                                   \
>> +		"for script in ${boot_scripts}; do "                      \
>> +			"if test -e ${devtype} ${devnum}:${rootpart} "    \
>> +					"${prefix}${script}; then "       \
>> +				"echo Found U-Boot script "               \
>> +					"${prefix}${script}; "            \
>> +				"run do_script_boot;"                     \
>> +				"echo SCRIPT FAILED; continuing...; "     \
> 
> This is not going to work, "continuing..." would be treated as command.

But I tested it:-)

It seems that U-Boot just ignores the unknown command (well, it prints
an error that I didn't notice) and continues on. So, it kinda works but
certainly doesn't do what's intended;-)

Thanks for pointing out the issues. I'll also have to revise the
Raspberry Pi patches that have the same issue.