* [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO
@ 2014-02-04 5:57 Inha Song
2014-02-04 6:33 ` Lukasz Majewski
2014-02-06 0:31 ` Minkyu Kang
0 siblings, 2 replies; 3+ messages in thread
From: Inha Song @ 2014-02-04 5:57 UTC (permalink / raw)
To: u-boot
This patch fix the u-boot shell problem on TRATS2 board.
- If hold the key while booting is in progress,
white spaces are written in u-boot shell.
Set Automatically clears after resetting Rx FIFO.
Signed-off-by: Inha Song <ideal.song@samsung.com>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/serial/serial_s5p.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c
index 89f5d68..98c62b4 100644
--- a/drivers/serial/serial_s5p.c
+++ b/drivers/serial/serial_s5p.c
@@ -100,8 +100,8 @@ static int serial_init_dev(const int dev_index)
{
struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
- /* enable FIFOs */
- writel(0x1, &uart->ufcon);
+ /* enable FIFOs, auto clear Rx FIFO */
+ writel(0x3, &uart->ufcon);
writel(0, &uart->umcon);
/* 8N1 */
writel(0x3, &uart->ulcon);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO
2014-02-04 5:57 [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO Inha Song
@ 2014-02-04 6:33 ` Lukasz Majewski
2014-02-06 0:31 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Lukasz Majewski @ 2014-02-04 6:33 UTC (permalink / raw)
To: u-boot
Hi Inha,
> This patch fix the u-boot shell problem on TRATS2 board.
> - If hold the key while booting is in progress,
> white spaces are written in u-boot shell.
>
> Set Automatically clears after resetting Rx FIFO.
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/serial/serial_s5p.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c
> index 89f5d68..98c62b4 100644
> --- a/drivers/serial/serial_s5p.c
> +++ b/drivers/serial/serial_s5p.c
> @@ -100,8 +100,8 @@ static int serial_init_dev(const int dev_index)
> {
> struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
>
> - /* enable FIFOs */
> - writel(0x1, &uart->ufcon);
> + /* enable FIFOs, auto clear Rx FIFO */
> + writel(0x3, &uart->ufcon);
> writel(0, &uart->umcon);
> /* 8N1 */
> writel(0x3, &uart->ulcon);
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO
2014-02-04 5:57 [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO Inha Song
2014-02-04 6:33 ` Lukasz Majewski
@ 2014-02-06 0:31 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2014-02-06 0:31 UTC (permalink / raw)
To: u-boot
On 04/02/14 14:57, Inha Song wrote:
> This patch fix the u-boot shell problem on TRATS2 board.
> - If hold the key while booting is in progress,
> white spaces are written in u-boot shell.
>
> Set Automatically clears after resetting Rx FIFO.
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/serial/serial_s5p.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
applied to u-boot-samsung
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-06 0:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-04 5:57 [U-Boot] [PATCH] serial: s5p: set automatically clears after resetting Rx FIFO Inha Song
2014-02-04 6:33 ` Lukasz Majewski
2014-02-06 0:31 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox