From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Mon, 10 Feb 2014 18:09:42 +0900
Subject: [U-Boot] [PATCH 5/9] arm:exynos: add common board file for
	exynos 4
In-Reply-To: <000001cf263d$76d89640$6489c2c0$%wilczek@samsung.com>
References: <1390832143-372-1-git-send-email-p.wilczek@samsung.com>
	<1390832143-372-6-git-send-email-p.wilczek@samsung.com>
	<52F490D5.70102@samsung.com>
	<003201cf23e0$3e34ae00$ba9e0a00$%wilczek@samsung.com>
	<52F4ABC9.2010703@samsung.com>
	<000001cf263d$76d89640$6489c2c0$%wilczek@samsung.com>
Message-ID: <52F89756.9070705@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Piotr,

On 10/02/14 17:52, Piotr Wilczek wrote:
> 
>> -----Original Message-----
>> From: Minkyu Kang [mailto:mk7.kang at samsung.com]
>> Sent: Friday, February 07, 2014 10:48 AM
>> To: Piotr Wilczek
>> Cc: u-boot at lists.denx.de; 'Kyungmin Park'; Lukasz Majewski; 'Jaehoon
>> Chung'; 'Inha Song'; 'Chanho Park'
>> Subject: Re: [PATCH 5/9] arm:exynos: add common board file for exynos 4
>>>>> diff --git a/board/samsung/common/board_exynos4.c
>>>>> b/board/samsung/common/board_exynos4.c
>>>>> new file mode 100644
>>>>> index 0000000..2d313e6
>>>>> --- /dev/null
>>>>> +++ b/board/samsung/common/board_exynos4.c
>>>>
>>>> I don't understand why need exynos4 common board file.
>>>> There's already exist board.c that is common board file for samsung.
>>>>
>>> Because in the board.c file, both common and board specific functions
>>> are added.
>>> Max 77686, eth, power, board late initialization functions are board
>>> specific.
>>> If they are removed, I will be able to use the board.c file.
>>
>> It seems to be wrapped with ifdef.
>> I think there's no problems to use same file.
>>
> Max77686 init implementation is different for Trats2 and ifdef will not help
> here.
> I think that max77686_init() function should be removed from the board.c
> file.

It's up to you.

> 
> Other board specific initializations I can resolve in the way it was done in
> board_init() function, if that's the preferred way.
> 
>> Thanks,
>> Minkyu Kang.
> 
> Best regrds,
> Piotr Wilczek
> 

Thanks,
Minkyu Kang.