From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 10 Feb 2014 10:30:37 +0100 Subject: [U-Boot] [PATCH] zynq: Use full tftpboot command instead of shortcut tftp In-Reply-To: <20140210101156.7dda4d0a@lilith> References: <20140210101156.7dda4d0a@lilith> Message-ID: <52F89C3D.2050706@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Albert, On 02/10/2014 10:11 AM, Albert ARIBAUD wrote: > Hi Michal, > > On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek > wrote: > >> The reason is enabling tftpput command where >> tftp shorcut stops to work for tftpboot. > > Do you think you could extend this patch to all config files where > the 'tftp' shortcut exists? This would prevent future issues on > targets other than Zynq and hopefully it is only a matter of grepping / > sed'ing through include/configs/*.h. Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error. It means for short variables I can't see any problem with it and definitely will be better to use full command names instead of shortcut. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: