From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm/lib: Add get_effective_memsize() to board.c
Date: Mon, 10 Feb 2014 14:33:47 -0800 [thread overview]
Message-ID: <52F953CB.8090601@freescale.com> (raw)
In-Reply-To: <1392070794.6733.362.camel@snotra.buserror.net>
On 02/10/2014 02:19 PM, Scott Wood wrote:
> On Mon, 2014-02-10 at 14:04 -0800, York Sun wrote:
>> This function has been around for powerpc. It is used for systems with
>> memory more than CONFIG_MAX_MEM_MAPPED. In case of non-contiguous memory,
>> this feature can limit U-boot to one block without going over the limit.
>>
>> Signed-off-by: York Sun <yorksun@freescale.com>
>> ---
>> arch/arm/lib/board.c | 20 +++++++++++++++++++-
>> 1 file changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
>> index b770e25..b31c8ff 100644
>> --- a/arch/arm/lib/board.c
>> +++ b/arch/arm/lib/board.c
>> @@ -263,6 +263,24 @@ init_fnc_t *init_sequence[] = {
>> NULL,
>> };
>>
>> +phys_size_t get_effective_memsize(void)
>> +{
>> +#ifndef CONFIG_VERY_BIG_RAM
>
> Whitespace
I think I have put a tab instead of a space.
>
>> + return gd->ram_size;
>> +#else
>> + /* limit stack to what we can reasonable map */
>> + return ((gd->ram_size > CONFIG_MAX_MEM_MAPPED) ?
>> + CONFIG_MAX_MEM_MAPPED : gd->ram_size);
>> +#endif
>> +}
>
> Is there anything really arch-specific about this function?
>
Not at all. It is not called by any other file either. I tried to move the
function phys_size_t get_effective_memsize(void) out, but I don't see which
common file fits this purpose.
York
next prev parent reply other threads:[~2014-02-10 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1392069859-24805-1-git-send-email-yorksun@freescale.com>
2014-02-10 22:18 ` [U-Boot] Fwd: [PATCH] arm/lib: Add get_effective_memsize() to board.c York Sun
[not found] ` <1392070794.6733.362.camel@snotra.buserror.net>
2014-02-10 22:33 ` York Sun [this message]
2014-02-10 22:37 ` [U-Boot] " Scott Wood
2014-02-10 22:55 ` York Sun
2014-02-10 23:00 ` Scott Wood
2014-02-10 23:03 ` York Sun
2014-02-11 8:21 ` Wolfgang Denk
2014-02-11 17:40 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F953CB.8090601@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox