From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] NET: fec_mxc: fix MDIO clock prescaler calculation
Date: Tue, 11 Feb 2014 10:51:18 +0100 [thread overview]
Message-ID: <52F9F296.1090108@denx.de> (raw)
In-Reply-To: <1391594051-4947-1-git-send-email-list-09_u-boot@tqsc.de>
Hi Marcus,
On 05/02/2014 10:54, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tqs.de>
>
> The prescaler value for MDC is calculated wrong for
> MX6S. Implement the same logic as linux here which handles
> ENET_MAC different then original FEC.
>
> Tested on a custom board with i.MX6S and 100MBit PHY
>
> Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
> ---
> drivers/net/fec_mxc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 3b2b995..4cefda4 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -128,8 +128,12 @@ static void fec_mii_setspeed(struct ethernet_regs *eth)
> * Set MII_SPEED = (1/(mii_speed * 2)) * System Clock
> * and do not drop the Preamble.
> */
> - writel((((imx_get_fecclk() / 1000000) + 2) / 5) << 1,
> - ð->mii_speed);
> + register u32 speed = DIV_ROUND_UP(imx_get_fecclk(), 5000000);
> +#ifdef FEC_QUIRK_ENET_MAC
> + speed--;
> +#endif
> + speed <<= 1;
> + writel(speed, ð->mii_speed);
> debug("%s: mii_speed %08x\n", __func__, readl(ð->mii_speed));
> }
Thanks for this - I go for merging..
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-02-11 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 9:54 [U-Boot] [PATCH] NET: fec_mxc: fix MDIO clock prescaler calculation Markus Niebel
2014-02-11 9:51 ` Stefano Babic [this message]
2014-02-11 10:34 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F9F296.1090108@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox