From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] driver/mxc_i2c: Move static data structure to global_data
Date: Tue, 11 Feb 2014 13:02:19 -0800 [thread overview]
Message-ID: <52FA8FDB.3030808@freescale.com> (raw)
In-Reply-To: <20140211205708.A76B0380439@gemini.denx.de>
On 02/11/2014 12:57 PM, Wolfgang Denk wrote:
> Dear York,
>
> In message <52FA8205.1090206@freescale.com> you wrote:
>>
>>> So ideally keep this data on the stack, and if there is no way around
>>> it, in the global data structure.
>>
>> Agreed. I tried to use global data at first, which upsets Tom. Tom suggested to
>> use linker script. I guess he was under the impression I was using SPL. Let me
>> try harder to use stack.
>
> well, to do something with the linker script, you need some memory
> somewhere you can use for this purpose. Your example showed SRAM. so
> if you do have SRAM on that board - why do you not use it for stack
> and GD? Where is your steck and GD right now?
>
The initial stack and GD are in SRAM. Of course they are moved to SDRAM after
initialization. I intend to spare SRAM for other purpose after relocation.
I am scratching my head trying to figure out how to put this variable "srdata"
in mxc_i2c.c into stack. Please give me some guidance if you have the idea on
top of your head.
York
next prev parent reply other threads:[~2014-02-11 21:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 22:02 [U-Boot] [PATCH] driver/mxc_i2c: Move static data structure to global_data York Sun
2014-02-10 22:10 ` Tom Rini
2014-02-10 22:28 ` York Sun
2014-02-10 22:45 ` Tom Rini
2014-02-10 22:47 ` York Sun
2014-02-11 18:01 ` York Sun
2014-02-11 21:46 ` York Sun
2014-02-12 14:41 ` Tom Rini
2014-02-11 2:34 ` York Sun
2014-02-11 19:25 ` Troy Kisky
2014-02-11 19:46 ` York Sun
2014-02-11 19:59 ` Wolfgang Denk
2014-02-11 20:03 ` York Sun
2014-02-11 20:57 ` Wolfgang Denk
2014-02-11 21:02 ` York Sun [this message]
2014-02-11 22:12 ` Wolfgang Denk
2014-02-11 22:20 ` York Sun
2014-02-12 14:27 ` Wolfgang Denk
2014-02-12 14:43 ` Tom Rini
2014-02-12 17:56 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA8FDB.3030808@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox