public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] armv8/cache: Change cache invalidate and flush function
Date: Thu, 13 Feb 2014 09:29:08 -0800	[thread overview]
Message-ID: <52FD00E4.3000603@freescale.com> (raw)
In-Reply-To: <4997fa.12c4.144296ae1fc.Coremail.fenghua@phytium.com.cn>

On 02/12/2014 08:04 PM, FengHua wrote:
> 
> 
> 
>> -----Original Messages-----
>> From: "York Sun" <yorksun@freescale.com>
>> Sent Time: 2014-02-11 05:55:54 (Tuesday)
>> To: albert.u.boot at aribaud.net
>> Cc: scottwood at freescale.com, "York Sun" <yorksun@freescale.com>, "David Feng" <fenghua@phytium.com.cn>
>> Subject: [PATCH 3/3] armv8/cache: Change cache invalidate and flush function
>>

<snip>

>> diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S
>> index e70c51d..7b9ac21 100644
>> --- a/arch/arm/cpu/armv8/start.S
>> +++ b/arch/arm/cpu/armv8/start.S
>> @@ -65,9 +65,9 @@ reset:
>>  0:
>>  
>>  	/* Cache/BPB/TLB Invalidate */
>> -	bl	__asm_flush_dcache_all		/* dCache clean&invalidate */
>>  	bl	__asm_invalidate_icache_all	/* iCache invalidate */
>>  	bl	__asm_invalidate_tlb_all	/* invalidate TLBs */
> How about remove the icache and tlb invalidate operations?

We can move the calling of __asm_invalidate_tlb_all to before mmu_setup, and
move calling __asm_invalidate_icache_all to before icache_enable. But leaving
them here makes sense as the initial setup procedure. And more important, it
won't get lost. These functions run very fast, not like invalidating dcache.

York

  parent reply	other threads:[~2014-02-13 17:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1392069354-24578-1-git-send-email-yorksun@freescale.com>
2014-02-10 21:58 ` [U-Boot] Fwd: [PATCH 1/3] armv8/cache: Consolidate setting for MAIR and TCR York Sun
     [not found] ` <1392069354-24578-3-git-send-email-yorksun@freescale.com>
2014-02-10 21:58   ` [U-Boot] Fwd: [PATCH 3/3] armv8/cache: Change cache invalidate and flush function York Sun
     [not found]   ` <4997fa.12c4.144296ae1fc.Coremail.fenghua@phytium.com.cn>
2014-02-13 17:29     ` York Sun [this message]
2014-02-13  3:13 ` [U-Boot] [PATCH 1/3] armv8/cache: Consolidate setting for MAIR and TCR FengHua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FD00E4.3000603@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox