public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: omap3: Fix tao3530/omap3_ha SPL boot hangup (GPIO clocks not enabled)
Date: Fri, 14 Feb 2014 12:08:49 +0100	[thread overview]
Message-ID: <52FDF941.6090803@denx.de> (raw)
In-Reply-To: <1392367637-21873-1-git-send-email-sr@denx.de>

Hi Stefan,

On 14/02/2014 09:47, Stefan Roese wrote:
> Patch f33b9bd3
> [arm: omap3: Enable clocks for peripherals only if they are used]
> breaks SPL booting on tao3530. Since some gpio input's are
> read to detect the board revision. But with this patch above, the
> clocks to the GPIO subsystems are not enabled per default any more.
> The GPIO banks need to be configured specifically now.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  include/configs/tao3530.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/configs/tao3530.h b/include/configs/tao3530.h
> index 9abfe82..9c04c23 100644
> --- a/include/configs/tao3530.h
> +++ b/include/configs/tao3530.h
> @@ -83,6 +83,13 @@
>  #define CONFIG_OMAP_HSMMC
>  #define CONFIG_DOS_PARTITION
>  
> +/* GPIO banks */
> +#define CONFIG_OMAP3_GPIO_2		/* GPIO32 ..63  is in GPIO bank 2 */
> +#define CONFIG_OMAP3_GPIO_3		/* GPIO64 ..95  is in GPIO bank 3 */
> +#define CONFIG_OMAP3_GPIO_4		/* GPIO96 ..127 is in GPIO bank 4 */
> +#define CONFIG_OMAP3_GPIO_5		/* GPIO128..159 is in GPIO bank 5 */
> +#define CONFIG_OMAP3_GPIO_6		/* GPIO160..191 is in GPIO bank 6 */
> +
>  /* commands to include */
>  #include <config_cmd_default.h>
>  
> 

I confirm the issue, I will send a similar patch for the mcx board.

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-02-14 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  8:47 [U-Boot] [PATCH] arm: omap3: Fix tao3530/omap3_ha SPL boot hangup (GPIO clocks not enabled) Stefan Roese
2014-02-14 11:08 ` Stefano Babic [this message]
2014-02-21 19:15 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FDF941.6090803@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox