public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] wandboard: Staticize usdhc1_pads
Date: Sun, 16 Feb 2014 13:15:43 +0100	[thread overview]
Message-ID: <5300ABEF.2060702@denx.de> (raw)
In-Reply-To: <1392483122-21852-1-git-send-email-festevam@gmail.com>

Hi Fabio,

On 15/02/2014 17:51, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Fix the following sparse warning:
> 
> wandboard.c:58:22: warning: symbol 'usdhc1_pads' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/wandboard/wandboard.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
> index 72e9bb2..dbced1c 100644
> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -55,7 +55,7 @@ static iomux_v3_cfg_t const uart1_pads[] = {
>  	MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
>  };
>  
> -iomux_v3_cfg_t const usdhc1_pads[] = {
> +static iomux_v3_cfg_t const usdhc1_pads[] = {
>  	MX6_PAD_SD1_CLK__SD1_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD1_CMD__SD1_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD1_DAT0__SD1_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),

Thanks for fix it. However, which gcc version reports these warnings ?
Surely I must update and test with a newer one: with gcc 4.6.4/4.7.2 I
saw no error.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2014-02-16 12:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 16:51 [U-Boot] [PATCH 1/5] wandboard: Staticize usdhc1_pads Fabio Estevam
2014-02-15 16:51 ` [U-Boot] [PATCH 2/5] mmc: Add a prototype for board_mmc_init() Fabio Estevam
2014-03-05 11:10   ` Stefano Babic
2014-02-15 16:52 ` [U-Boot] [PATCH 3/5] wandboard: Fix sparse warning Fabio Estevam
2014-03-05 11:10   ` Stefano Babic
2014-02-15 16:52 ` [U-Boot] [PATCH 4/5] wandboard: Include <input.h> Fabio Estevam
2014-03-05 11:11   ` Stefano Babic
2014-02-15 16:52 ` [U-Boot] [PATCH 5/5] fb: Add a prototype for board_video_skip() Fabio Estevam
2014-03-05 11:11   ` Stefano Babic
2014-02-16 12:15 ` Stefano Babic [this message]
2014-02-16 14:42   ` [U-Boot] [PATCH 1/5] wandboard: Staticize usdhc1_pads Fabio Estevam
2014-02-16 15:29     ` Stefano Babic
2014-03-05 11:10 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5300ABEF.2060702@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox