From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 19 Feb 2014 10:46:09 -0700 Subject: [U-Boot] [RFC PATCH 2/3] move the beaglebones over to the generic configs In-Reply-To: <1392659798-1665-3-git-send-email-dennis@ausil.us> References: <1392659798-1665-1-git-send-email-dennis@ausil.us> <1392659798-1665-3-git-send-email-dennis@ausil.us> Message-ID: <5304EDE1.9050606@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/17/2014 10:56 AM, Dennis Gilmore wrote: > Signed-off-by: Dennis Gilmore Patch description? > diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h > #define CONFIG_EXTRA_ENV_SETTINGS \ > "loadaddr=0x80200000\0" \ > - "fdtaddr=0x80F80000\0" \ > + "fdt_addr=0x80F80000\0" \ > + "fdt_addr_r=0x80F80000\0" \ Why set both? Surely only fdt_addr_r is required/useful? > - "mmcroot=/dev/mmcblk0p2 ro\0" \ That implies that rootpart=1 in config_distro_bootcmd.h isn't correct for this board? > - "rootpath=/export/rootfs\0" \ > - "nfsopts=nolock\0" \ > - "static_ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:${hostname}" \ > - "::off\0" \ > - "ramroot=/dev/ram0 rw ramdisk_size=65536 initrd=${rdaddr},64M\0" \ > - "ramrootfstype=ext2\0" \ > - "mmcargs=setenv bootargs console=${console} " \ > - "${optargs} " \ > - "root=${mmcroot} " \ > - "rootfstype=${mmcrootfstype}\0" \ > - "spiroot=/dev/mtdblock4 rw\0" \ > - "spirootfstype=jffs2\0" \ > - "spisrcaddr=0xe0000\0" \ > - "spiimgsize=0x362000\0" \ > - "spibusno=0\0" \ > - "spiargs=setenv bootargs console=${console} " \ > - "${optargs} " \ > - "root=${spiroot} " \ > - "rootfstype=${spirootfstype}\0" \ > - "netargs=setenv bootargs console=${console} " \ > - "${optargs} " \ > - "root=/dev/nfs " \ > - "nfsroot=${serverip}:${rootpath},${nfsopts} rw " \ > - "ip=dhcp\0" \ I'm not at all familiar with this board, but this seems to be removing NFS and SPI boot capabilities, maybe others too?