[U-Boot] [PATCH] kbuild,tegra124: add dummy obj- for Kbuild

Stephen Warren
2014-02-19T20:44:43Z

On 02/19/2014 01:40 PM, Tom Rini wrote:
> On Wed, Feb 19, 2014 at 09:36:14AM -0700, Stephen Warren wrote:
>> On 02/19/2014 07:46 AM, Albert ARIBAUD wrote:
>>> Hi Masahiro,
>>>
>>> On Wed, 19 Feb 2014 22:26:43 +0900, Masahiro Yamada
>>> <yamada.m@jp.panasonic.com> wrote:
>>>
>>>> In Kbuild, every makefile must have non-empty obj- or obj-y.
>>>> Otherwise, built-in.o will not be created and the link stage
>>>> will fail.
>> ...
>>>> diff --git a/arch/arm/cpu/armv7/tegra124/Makefile b/arch/arm/cpu/armv7/tegra124/Makefile
>> ...
>>>> +# necessary to create built-in.o
>>>> +obj- := __dummy__.o
>>
>> obj- or obj-y?
>>
>> Adding something to obj-, which presumably isn't used at all, seems very
>> odd.
>
> Why do we even need arch/arm/cpu/armv7/tegra124/Makefile ? I assume we
> need the config.mk because we can't stick CONFIG_ARCH_DEVICE_TREE into
> the config header?

At least with the current build system, if I delete it, the build fails:

> + make BUILD_DIR=/home/swarren/shared/git_wa/tegra-uboot-flasher/_build/venice2/u-boot -s -j9
> /home/swarren/shared/git_wa/tegra-uboot-flasher/u-boot/scripts/Makefile.build:11: Makefile: No such file or directory
> make[1]: *** No rule to make target `Makefile'. Stop.
> make: *** [/home/swarren/shared/git_wa/tegra-uboot-flasher/_build/venice2/u-boot/arch/arm/cpu/armv7/tegra124/built-in.o] Error 2