From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild,tegra124: add dummy obj- for Kbuild
Date: Fri, 21 Feb 2014 09:33:43 -0700 [thread overview]
Message-ID: <53077FE7.50903@wwwdotorg.org> (raw)
In-Reply-To: <20140221204505.40BB.AA925319@jp.panasonic.com>
On 02/21/2014 04:45 AM, Masahiro Yamada wrote:
> On Thu, 20 Feb 2014 09:15:21 -0700 Stephen Warren wrote:
>> On 02/20/2014 01:24 AM, Masahiro Yamada wrote:
>>> On Wed, 19 Feb 2014 09:36:14 -0700 Stephen Warren wrote:
>>>> On 02/19/2014 07:46 AM, Albert ARIBAUD wrote:
>>>>> On Wed, 19 Feb 2014 22:26:43 +0900, Masahiro wrote:
>>>>>
>>>>>> In Kbuild, every makefile must have non-empty obj- or obj-y.
>>>>>> Otherwise, built-in.o will not be created and the link stage
>>>>>> will fail.
>>>> ...
>>>>>> diff --git a/arch/arm/cpu/armv7/tegra124/Makefile b/arch/arm/cpu/armv7/tegra124/Makefile
>>>> ...
>>>>>> +# necessary to create built-in.o
>>>>>> +obj- := __dummy__.o
>>>>
>>>> obj- or obj-y?
>>>
>>> Definitely obj-.
>>
>> Really? Why would such a variable even exist or be used. Only obj-n or
>> obj-y should exist; "" isn't a valid y/n value.
>
> All defined CONFIG macros are included in
> include/autoconf.mk (and include/spl-autoconf.mk,
> include/tpl-autoconf.mk for SPL, TPL, respectively)
>
> If CONFIG_FOO is defined in your config header,
> CONFIG_FOO=y will apear in include/autoconf.mk
> Otherwise, it does not appear in include/autoconf.mk.
...
> Is this clearer now?
OK, that makes sense.
I would have expected that Kbuild could detect obj-y is empty, and skip
building builtin.o, and skip attempting to link it in to the parent
directory too. However, if it doesn't do that, then this all makes
sense. Thanks.
next prev parent reply other threads:[~2014-02-21 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 13:26 [U-Boot] [PATCH] kbuild,tegra124: add dummy obj- for Kbuild Masahiro Yamada
2014-02-19 14:46 ` Albert ARIBAUD
2014-02-19 16:36 ` Stephen Warren
2014-02-19 20:40 ` Tom Rini
2014-02-19 20:44 ` Stephen Warren
2014-02-20 8:35 ` Masahiro Yamada
2014-02-20 8:24 ` Masahiro Yamada
2014-02-20 16:15 ` Stephen Warren
2014-02-21 11:45 ` Masahiro Yamada
2014-02-21 16:33 ` Stephen Warren [this message]
2014-02-20 8:23 ` Masahiro Yamada
2014-02-20 9:06 ` Albert ARIBAUD
2014-02-19 20:51 ` Tom Rini
2014-02-20 8:22 ` Masahiro Yamada
2014-02-20 13:25 ` Tom Rini
2014-02-19 21:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53077FE7.50903@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox