* [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033
@ 2013-12-23 7:51 Zhao Qiang
2014-02-24 23:54 ` York Sun
2014-02-25 17:30 ` York Sun
0 siblings, 2 replies; 4+ messages in thread
From: Zhao Qiang @ 2013-12-23 7:51 UTC (permalink / raw)
To: u-boot
Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" before
while "if (phydev->supported & SUPPORTED_Autoneg)" now.
So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033
to enable autonegotiation.
Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
drivers/net/phy/atheros.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
index b20b4df..1ee2226 100644
--- a/drivers/net/phy/atheros.c
+++ b/drivers/net/phy/atheros.c
@@ -13,6 +13,7 @@ static int ar8021_config(struct phy_device *phydev)
phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x3D47);
+ phydev->supported = phydev->drv->features;
return 0;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033
2013-12-23 7:51 [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033 Zhao Qiang
@ 2014-02-24 23:54 ` York Sun
2014-02-25 18:41 ` Joe Hershberger
2014-02-25 17:30 ` York Sun
1 sibling, 1 reply; 4+ messages in thread
From: York Sun @ 2014-02-24 23:54 UTC (permalink / raw)
To: u-boot
On 12/22/2013 11:51 PM, Zhao Qiang wrote:
> Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" before
> while "if (phydev->supported & SUPPORTED_Autoneg)" now.
> So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033
> to enable autonegotiation.
>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> drivers/net/phy/atheros.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
> index b20b4df..1ee2226 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -13,6 +13,7 @@ static int ar8021_config(struct phy_device *phydev)
> phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
> phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x3D47);
>
> + phydev->supported = phydev->drv->features;
> return 0;
> }
>
>
Joe,
This patch has been floating for a while. If it is OK, I'd like to take it in
with other 85xx patches.
York
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033
2014-02-24 23:54 ` York Sun
@ 2014-02-25 18:41 ` Joe Hershberger
0 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2014-02-25 18:41 UTC (permalink / raw)
To: u-boot
On Mon, Feb 24, 2014 at 5:54 PM, York Sun <yorksun@freescale.com> wrote:
> On 12/22/2013 11:51 PM, Zhao Qiang wrote:
> > Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)"
> before
> > while "if (phydev->supported & SUPPORTED_Autoneg)" now.
> > So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033
> > to enable autonegotiation.
> >
> > Signed-off-by: Zhao Qiang <B45475@freescale.com>
> > ---
> > drivers/net/phy/atheros.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
> > index b20b4df..1ee2226 100644
> > --- a/drivers/net/phy/atheros.c
> > +++ b/drivers/net/phy/atheros.c
> > @@ -13,6 +13,7 @@ static int ar8021_config(struct phy_device *phydev)
> > phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
> > phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x3D47);
> >
> > + phydev->supported = phydev->drv->features;
> > return 0;
> > }
> >
> >
>
> Joe,
>
> This patch has been floating for a while. If it is OK, I'd like to take it
> in
> with other 85xx patches.
>
>
Sorry for the delayed response... This change seems fine.
-Joe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033
2013-12-23 7:51 [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033 Zhao Qiang
2014-02-24 23:54 ` York Sun
@ 2014-02-25 17:30 ` York Sun
1 sibling, 0 replies; 4+ messages in thread
From: York Sun @ 2014-02-25 17:30 UTC (permalink / raw)
To: u-boot
On 12/22/2013 11:51 PM, Zhao Qiang wrote:
> Function "genphy_parse_link()" used "if (mii_reg & BMSR_ANEGCAPABLE)" before
> while "if (phydev->supported & SUPPORTED_Autoneg)" now.
> So assign "phydev->supported" to "phydev->drv->features" for ar8031/8033
> to enable autonegotiation.
>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
Applied to u-boot-mpc85xx/master. Thanks.
York
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-25 18:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-23 7:51 [U-Boot] [PATCH] ar8031/8033/phy:enable autonegotiation for ar8031/8033 Zhao Qiang
2014-02-24 23:54 ` York Sun
2014-02-25 18:41 ` Joe Hershberger
2014-02-25 17:30 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox