From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fix: trats: clock setup: enable all clocks in clk_gate_block.
Date: Wed, 26 Feb 2014 09:08:50 +0100 [thread overview]
Message-ID: <530DA112.7050001@samsung.com> (raw)
In-Reply-To: <20140225175831.GB16805@bill-the-cat>
Hello Tom,
On 02/25/2014 06:58 PM, Tom Rini wrote:
> On Tue, Feb 25, 2014 at 06:37:43PM +0100, Przemyslaw Marczak wrote:
>
>> This change fixes kernel boot issue on trats. Some drivers in kernel 3.10
>> expects that proper clocks are enabled, e.g. mfc driver clock.
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> cc: Lukasz Majewski <l.majewski@samsung.com>
>> cc: Minkyu Kang <mk7.kang@samsung.com>
>> cc: Tom Rini <trini@ti.com>
>
> My first inclination is NAK, the kernel is responsible for enabling
> clocks that it needs and we spent a while in TI-land dealing with the
> fallout in various ways of enabling everything in U-Boot (you run into
> various types of PM-related fun). If you have a vendor kernel you need
> to support this on, you need a vendor U-Boot with this work-around until
> the kernel is fixed.
>
Thank you for reply. You're right, it wasn't good idea. So I will wait
for such fix in mainline kernel.
Regards
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
prev parent reply other threads:[~2014-02-26 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 17:37 [U-Boot] [PATCH] fix: trats: clock setup: enable all clocks in clk_gate_block Przemyslaw Marczak
2014-02-25 17:58 ` Tom Rini
2014-02-26 8:08 ` Przemyslaw Marczak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530DA112.7050001@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox