[U-Boot] [PATCH] fix: trats: clock setup: enable all clocks in clk_gate_block.

[U-Boot] [PATCH] fix: trats: clock setup: enable all clocks in clk_gate_block.

[Przemyslaw Marczak]

This change fixes kernel boot issue on trats. Some drivers in kernel 3.10
expects that proper clocks are enabled, e.g. mfc driver clock.

Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
cc: Lukasz Majewski <l.majewski@samsung.com>
cc: Minkyu Kang <mk7.kang@samsung.com>
cc: Tom Rini <trini@ti.com>
---
 board/samsung/trats/setup.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/samsung/trats/setup.h b/board/samsung/trats/setup.h
index 2f5ccb1..efb392c 100644
--- a/board/samsung/trats/setup.h
+++ b/board/samsung/trats/setup.h
@@ -611,7 +611,7 @@
 					  | (CLK_EN << BIT_PERIL_CLK_SLIMBUS)))
 #define CLK_GATE_IP_PERIR_VAL		(CLK_GATE_IP_PERIR_ALL_DIS \
 					| ~((CLK_EN << BIT_PERIR_CLK_KEYIF)))
-#define CLK_GATE_BLOCK_VAL		CLK_GATE_BLOCK_ALL_DIS
+#define CLK_GATE_BLOCK_VAL		CLK_GATE_BLOCK_ALL_EN
 
 /* PS_HOLD: Data Hight, Output En */
 #define BIT_DAT				8
-- 
1.7.9.5

[U-Boot] [PATCH] fix: trats: clock setup: enable all clocks in clk_gate_block.

[Tom Rini]

On Tue, Feb 25, 2014 at 06:37:43PM +0100, Przemyslaw Marczak wrote:

> This change fixes kernel boot issue on trats. Some drivers in kernel 3.10
> expects that proper clocks are enabled, e.g. mfc driver clock.
> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> cc: Lukasz Majewski <l.majewski@samsung.com>
> cc: Minkyu Kang <mk7.kang@samsung.com>
> cc: Tom Rini <trini@ti.com>

My first inclination is NAK, the kernel is responsible for enabling
clocks that it needs and we spent a while in TI-land dealing with the
fallout in various ways of enabling everything in U-Boot (you run into
various types of PM-related fun).  If you have a vendor kernel you need
to support this on, you need a vendor U-Boot with this work-around until
the kernel is fixed.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140225/440d893e/attachment.pgp>

[U-Boot] [PATCH] fix: trats: clock setup: enable all clocks in clk_gate_block.

[Przemyslaw Marczak]

Hello Tom,
On 02/25/2014 06:58 PM, Tom Rini wrote:
> On Tue, Feb 25, 2014 at 06:37:43PM +0100, Przemyslaw Marczak wrote:
>
>> This change fixes kernel boot issue on trats. Some drivers in kernel 3.10
>> expects that proper clocks are enabled, e.g. mfc driver clock.
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> cc: Lukasz Majewski <l.majewski@samsung.com>
>> cc: Minkyu Kang <mk7.kang@samsung.com>
>> cc: Tom Rini <trini@ti.com>
>
> My first inclination is NAK, the kernel is responsible for enabling
> clocks that it needs and we spent a while in TI-land dealing with the
> fallout in various ways of enabling everything in U-Boot (you run into
> various types of PM-related fun).  If you have a vendor kernel you need
> to support this on, you need a vendor U-Boot with this work-around until
> the kernel is fixed.
>

Thank you for reply. You're right, it wasn't good idea. So I will wait 
for such fix in mainline kernel.

Regards
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com