From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Fri, 28 Feb 2014 11:28:43 +0100 Subject: [U-Boot] [PATCH v3 1/2] watchdog/denali: Adding DesignWare watchdog driver support In-Reply-To: <1393530776.1993.1.camel@clsee-VirtualBox.altera.com> References: <1393016221-8053-1-git-send-email-clsee@altera.com> <530AF9E8.8080207@monstr.eu> <1393530776.1993.1.camel@clsee-VirtualBox.altera.com> Message-ID: <531064DB.6080909@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/27/2014 08:52 PM, Chin Liang See wrote: > Hi Michal, > > On Mon, 2014-02-24 at 08:51 +0100, Michal Simek wrote: >> On 02/21/2014 09:57 PM, Chin Liang See wrote: >>> To add the DesignWare watchdog driver support. It required >>> information such as register base address and clock info from >>> configuration header file within include/configs folder. >>> >>> Signed-off-by: Chin Liang See >>> Cc: Anatolij Gustschin >>> Cc: Albert Aribaud >>> Cc: Heiko Schocher >>> Cc: Tom Rini >>> --- >>> Changes for v3 >>> - Split to 2 series patch >>> Changes for v2 >>> - Enable this driver at socfpga_cyclone5 board >>> --- >>> drivers/watchdog/Makefile | 1 + >>> drivers/watchdog/designware_wdt.c | 73 +++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 74 insertions(+) >>> create mode 100644 drivers/watchdog/designware_wdt.c >>> >> >> Checkpatch. >> total: 0 errors, 1 warnings, 1 checks, 77 lines checked > > Fixed > >> >> >>> diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile >>> index 06ced10..0276a10 100644 >>> --- a/drivers/watchdog/Makefile >>> +++ b/drivers/watchdog/Makefile >>> @@ -15,3 +15,4 @@ obj-$(CONFIG_S5P) += s5p_wdt.o >>> obj-$(CONFIG_XILINX_TB_WATCHDOG) += xilinx_tb_wdt.o >>> obj-$(CONFIG_BFIN_WATCHDOG) += bfin_wdt.o >>> obj-$(CONFIG_OMAP_WATCHDOG) += omap_wdt.o >>> +obj-$(CONFIG_DESIGNWARE_WATCHDOG) += designware_wdt.o >>> diff --git a/drivers/watchdog/designware_wdt.c b/drivers/watchdog/designware_wdt.c >>> new file mode 100644 >>> index 0000000..cb88844 >>> --- /dev/null >>> +++ b/drivers/watchdog/designware_wdt.c >>> @@ -0,0 +1,73 @@ >>> +/* >>> + * Copyright (C) 2013 Altera Corporation >> >> 2014? > > Oops, good catch. Fixed > >> >> >>> + * >>> + * SPDX-License-Identifier: GPL-2.0+ >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#define DW_WDT_CR 0x00 >>> +#define DW_WDT_TORR 0x04 >>> +#define DW_WDT_CRR 0x0C >>> + >>> +#define DW_WDT_CR_EN_OFFSET 0x00 >>> +#define DW_WDT_CR_RMOD_OFFSET 0x01 >>> +#define DW_WDT_CR_RMOD_VAL 0x00 >>> +#define DW_WDT_CRR_RESTART_VAL 0x76 >>> + >>> +/* >>> + * Set the watchdog time interval. >>> + * Counter is 32 bit. >>> + */ >>> +int designware_wdt_settimeout(unsigned int timeout) >>> +{ >>> + signed int i; >> >> you should separate variables from code. > > Actually I am trying to avoid to create a new header as its just few > simple defines. don't get you. I just thought to add one more blank line below this line. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: