From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Fri, 28 Feb 2014 11:31:53 +0100 Subject: [U-Boot] [PATCH v3 2/2] socfpga: Adding DesignWare watchdog support In-Reply-To: <1393530953.1993.3.camel@clsee-VirtualBox.altera.com> References: <1393016264-8092-1-git-send-email-clsee@altera.com> <530AFA54.2070401@monstr.eu> <1393530953.1993.3.camel@clsee-VirtualBox.altera.com> Message-ID: <53106599.4060602@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/27/2014 08:55 PM, Chin Liang See wrote: > Hi Michal, > > On Mon, 2014-02-24 at 08:52 +0100, Michal Simek wrote: >> On 02/21/2014 09:57 PM, Chin Liang See wrote: >>> To enable the DesignWare watchdog support at SOCFPGA Cyclone V >>> dev kit. >>> >>> Signed-off-by: Chin Liang See >>> Cc: Anatolij Gustschin >>> Cc: Albert Aribaud >>> Cc: Heiko Schocher >>> Cc: Tom Rini >>> --- >>> Changes for v3 >>> - Split to 2 series patch >>> Changes for v2 >>> - Enable this driver at socfpga_cyclone5 board >>> --- >>> .../include/asm/arch-socfpga/socfpga_base_addrs.h | 1 + >>> include/configs/socfpga_cyclone5.h | 13 +++++++++++++ >>> 2 files changed, 14 insertions(+) >>> >>> diff --git a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h >>> index 20f12e0..5f73824 100644 >>> --- a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h >>> +++ b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h >>> @@ -11,6 +11,7 @@ >>> #define SOCFPGA_UART0_ADDRESS 0xffc02000 >>> #define SOCFPGA_UART1_ADDRESS 0xffc03000 >>> #define SOCFPGA_OSC1TIMER0_ADDRESS 0xffd00000 >>> +#define SOCFPGA_L4WD0_ADDRESS 0xffd02000 >>> #define SOCFPGA_CLKMGR_ADDRESS 0xffd04000 >>> #define SOCFPGA_RSTMGR_ADDRESS 0xffd05000 >>> #define SOCFPGA_SYSMGR_ADDRESS 0xffd08000 >>> diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h >>> index fc921ee..1b78ccb 100644 >>> --- a/include/configs/socfpga_cyclone5.h >>> +++ b/include/configs/socfpga_cyclone5.h >>> @@ -207,6 +207,16 @@ >>> #define CONFIG_ENV_IS_NOWHERE >>> >>> /* >>> + * L4 Watchdog >>> + */ >> >> Why multiline comment here? > > Oh its just for easy reading. > >> >>> +#define CONFIG_HW_WATCHDOG >>> +#define CONFIG_HW_WATCHDOG_TIMEOUT_MS 2000 >>> +#define CONFIG_DESIGNWARE_WATCHDOG >>> +#define CONFIG_DW_WDT_BASE SOCFPGA_L4WD0_ADDRESS >> >> Why not just use SOCFPGA_L4WD0_ADDRESS directly? > > Nope, cause this driver might be used by other platform. ok It means that SOCFPGA_L4WD0_ADDRESS is system controller right? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: