* [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board
@ 2014-03-06 20:33 John de la Garza
2014-03-07 7:20 ` Andreas Bießmann
2014-03-08 17:19 ` Gerhard Sittig
0 siblings, 2 replies; 5+ messages in thread
From: John de la Garza @ 2014-03-06 20:33 UTC (permalink / raw)
To: u-boot
Signed-off-by: John de la Garza <john@jjdev.com>
---
arch/arm/include/asm/arch-at91/at91_rstc.h | 2 +-
include/configs/at91sam9260ek.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-at91/at91_rstc.h b/arch/arm/include/asm/arch-at91/at91_rstc.h
index a942342..59be96b 100644
--- a/arch/arm/include/asm/arch-at91/at91_rstc.h
+++ b/arch/arm/include/asm/arch-at91/at91_rstc.h
@@ -25,7 +25,7 @@ typedef struct at91_rstc {
#endif /* __ASSEMBLY__ */
-#define AT91_RSTC_KEY 0xA5000000
+#define AT91_RSTC_KEY 0xA5
#define AT91_RSTC_CR_PROCRST 0x00000001
#define AT91_RSTC_CR_PERRST 0x00000004
diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
index 73917b0..53bef35 100644
--- a/include/configs/at91sam9260ek.h
+++ b/include/configs/at91sam9260ek.h
@@ -177,6 +177,7 @@
#define CONFIG_SYS_NO_FLASH 1
/* Ethernet */
+#define CONFIG_MACB_SEARCH_PHY
#define CONFIG_MACB 1
#define CONFIG_RMII 1
#define CONFIG_NET_RETRY_COUNT 20
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board
2014-03-06 20:33 [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board John de la Garza
@ 2014-03-07 7:20 ` Andreas Bießmann
2014-03-08 17:19 ` Gerhard Sittig
1 sibling, 0 replies; 5+ messages in thread
From: Andreas Bießmann @ 2014-03-07 7:20 UTC (permalink / raw)
To: u-boot
Dear John de la Garza,
this is a pure resent of [1]. Please read [2] and especially [3] on
sending updated patches.
On 06.03.14 21:33, John de la Garza wrote:
> Signed-off-by: John de la Garza <john@jjdev.com>
> ---
> arch/arm/include/asm/arch-at91/at91_rstc.h | 2 +-
> include/configs/at91sam9260ek.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-at91/at91_rstc.h b/arch/arm/include/asm/arch-at91/at91_rstc.h
> index a942342..59be96b 100644
> --- a/arch/arm/include/asm/arch-at91/at91_rstc.h
> +++ b/arch/arm/include/asm/arch-at91/at91_rstc.h
> @@ -25,7 +25,7 @@ typedef struct at91_rstc {
>
> #endif /* __ASSEMBLY__ */
>
> -#define AT91_RSTC_KEY 0xA5000000
> +#define AT91_RSTC_KEY 0xA5
I have to NAK this again, you failed to respond on [4]. I may be wrong,
but then please elaborate your change in detail.
Best regards
Andreas Bie?mann
[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/180060
[2] http://www.denx.de/wiki/U-Boot/Patches
[3]
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
[4] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/180063
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board
2014-03-06 20:33 [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board John de la Garza
2014-03-07 7:20 ` Andreas Bießmann
@ 2014-03-08 17:19 ` Gerhard Sittig
1 sibling, 0 replies; 5+ messages in thread
From: Gerhard Sittig @ 2014-03-08 17:19 UTC (permalink / raw)
To: u-boot
On Thu, Mar 06, 2014 at 12:33 -0800, John de la Garza wrote:
>
> Signed-off-by: John de la Garza <john@jjdev.com>
Assuming that you fix something which isn't obvious, the commit
message is incredibly short (it's empty).
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board
@ 2014-02-11 2:54 johnd
2014-02-11 7:24 ` Andreas Bießmann
0 siblings, 1 reply; 5+ messages in thread
From: johnd @ 2014-02-11 2:54 UTC (permalink / raw)
To: u-boot
---
arch/arm/include/asm/arch-at91/at91_rstc.h | 2 +-
include/configs/at91sam9260ek.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-at91/at91_rstc.h b/arch/arm/include/asm/arch-at91/at91_rstc.h
index a942342..59be96b 100644
--- a/arch/arm/include/asm/arch-at91/at91_rstc.h
+++ b/arch/arm/include/asm/arch-at91/at91_rstc.h
@@ -25,7 +25,7 @@ typedef struct at91_rstc {
#endif /* __ASSEMBLY__ */
-#define AT91_RSTC_KEY 0xA5000000
+#define AT91_RSTC_KEY 0xA5
#define AT91_RSTC_CR_PROCRST 0x00000001
#define AT91_RSTC_CR_PERRST 0x00000004
diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
index 73917b0..53bef35 100644
--- a/include/configs/at91sam9260ek.h
+++ b/include/configs/at91sam9260ek.h
@@ -177,6 +177,7 @@
#define CONFIG_SYS_NO_FLASH 1
/* Ethernet */
+#define CONFIG_MACB_SEARCH_PHY
#define CONFIG_MACB 1
#define CONFIG_RMII 1
#define CONFIG_NET_RETRY_COUNT 20
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board
2014-02-11 2:54 johnd
@ 2014-02-11 7:24 ` Andreas Bießmann
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Bießmann @ 2014-02-11 7:24 UTC (permalink / raw)
To: u-boot
Dear johnd,
SoB line missing!
On 11.02.14 03:54, johnd wrote:
> ---
> arch/arm/include/asm/arch-at91/at91_rstc.h | 2 +-
> include/configs/at91sam9260ek.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-at91/at91_rstc.h b/arch/arm/include/asm/arch-at91/at91_rstc.h
> index a942342..59be96b 100644
> --- a/arch/arm/include/asm/arch-at91/at91_rstc.h
> +++ b/arch/arm/include/asm/arch-at91/at91_rstc.h
> @@ -25,7 +25,7 @@ typedef struct at91_rstc {
>
> #endif /* __ASSEMBLY__ */
>
> -#define AT91_RSTC_KEY 0xA5000000
> +#define AT91_RSTC_KEY 0xA5
This change is wrong, the RSTC key is located in RSTC_CR[31:24], your
change will move the constant to RSTC_CR[8:0]!
>
> #define AT91_RSTC_CR_PROCRST 0x00000001
> #define AT91_RSTC_CR_PERRST 0x00000004
> diff --git a/include/configs/at91sam9260ek.h b/include/configs/at91sam9260ek.h
> index 73917b0..53bef35 100644
> --- a/include/configs/at91sam9260ek.h
> +++ b/include/configs/at91sam9260ek.h
> @@ -177,6 +177,7 @@
> #define CONFIG_SYS_NO_FLASH 1
>
> /* Ethernet */
> +#define CONFIG_MACB_SEARCH_PHY
That change would be accepted, if the SoB line is available.
> #define CONFIG_MACB 1
> #define CONFIG_RMII 1
> #define CONFIG_NET_RETRY_COUNT 20
>
Best regards
Andreas Bie?mann
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-08 17:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 20:33 [U-Boot] [PATCH] arch-at91: Gets ethernet working on at91sam9g20 board John de la Garza
2014-03-07 7:20 ` Andreas Bießmann
2014-03-08 17:19 ` Gerhard Sittig
-- strict thread matches above, loose matches on Subject: below --
2014-02-11 2:54 johnd
2014-02-11 7:24 ` Andreas Bießmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox