From: Hannes Petermaier <hannes@petermaier.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] lcd: Add support for CONFIG_LCD_NOSTDOUT
Date: Sat, 08 Mar 2014 20:46:06 +0100 [thread overview]
Message-ID: <531B737E.1050300@petermaier.org> (raw)
In-Reply-To: <20140306194905.GJ3327@book.gsilab.sittig.org>
Hi Gerhard,
On 2014-03-06 20:49, Gerhard Sittig wrote:
> In general U-Boot tries to get away from the multitude of ifdefs
> where possible. I'm afraid adding a new one needs a very good
> reason to get perceived as welcome.
By the way i've found a passage within README, which tells to do so as
id id:
'* If you modify existing code, make sure that your new code does not
add to the memory footprint of the code ;-) Small is beautiful!
When adding new features, these should compile conditionally only
(using #ifdef), and the resulting code with the new feature
disabled must not need more memory than the old code without your
modification.
'
whats your opinion about this ?
> virtually yours
> Gerhard Sittig
best regards,
Hannes
next prev parent reply other threads:[~2014-03-08 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:26 [U-Boot] [PATCH] lcd: Add support for CONFIG_LCD_NOSTDOUT Hannes Petermaier
2014-03-06 19:49 ` Gerhard Sittig
2014-03-06 20:28 ` Hannes Petermaier
2014-03-08 19:46 ` Hannes Petermaier [this message]
2014-03-10 19:44 ` Gerhard Sittig
2014-05-03 18:34 ` Jeroen Hofstee
2014-05-05 6:21 ` Hannes Petermaier
2014-08-11 13:52 ` Anatolij Gustschin
2015-02-04 9:05 ` Hannes Petermaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531B737E.1050300@petermaier.org \
--to=hannes@petermaier.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox