From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Mon, 10 Mar 2014 11:24:57 -0600
Subject: [U-Boot] [PATCH V2 1/3] part_efi: move uuid_string() and
 string_uuid() to lib/uuid.c
In-Reply-To: <afb7d9d334d463a843c4615e67661e9fcae5b709.1394037321.git.p.marczak@samsung.com>
References: <72629ef58556732156fadf26a2a48be85704f224.1393600504.git.p.marczak@samsung.com>
	<afb7d9d334d463a843c4615e67661e9fcae5b709.1394037321.git.p.marczak@samsung.com>
Message-ID: <531DF569.20402@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/05/2014 09:45 AM, Przemyslaw Marczak wrote:
> Changes:
> Move functions:
> - disk/part_efi.c uuid_string() to lib/uuid.c -> uuid_bin_to_str()
> - disk/part_efi.c string_uuid() to lib/uuid.c -> uuid_str_to_bin()
> 
> Update files:
> - include/common.h
> - disk/part_efi.c
> - lib/Makefile

That's not a particularly useful patch description. How about:

Move uuid<->string conversion functions into lib/uuid.c so they can be
used by code outside part_efi.c. Rename uuid_string() to
uuid_bin_to_str(), so that's the naming is consistent with the existing
uuid_str_to_bin(). Add an error return code to uuid_str_to_bin().
Convert existing users to the new library functions.

This one patch,
Acked-by: Stephen Warren <swarren@nvidia.com>

> diff --git a/lib/Makefile b/lib/Makefile

>  obj-$(CONFIG_BOOTP_PXE) += uuid.o
> +obj-$(CONFIG_PARTITION_UUIDS) += uuid.o

Oh, I hope listing uuid.o twice in obj-y won't cause any issue...