From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 10 Mar 2014 13:39:11 -0400 Subject: [U-Boot] [PATCH V2 1/3] part_efi: move uuid_string() and string_uuid() to lib/uuid.c In-Reply-To: <531DF68A.3020106@wwwdotorg.org> References: <72629ef58556732156fadf26a2a48be85704f224.1393600504.git.p.marczak@samsung.com> <531DF68A.3020106@wwwdotorg.org> Message-ID: <531DF8BF.2050004@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/10/2014 01:29 PM, Stephen Warren wrote: > On 03/05/2014 09:45 AM, Przemyslaw Marczak wrote: >> Changes: >> Move functions: >> - disk/part_efi.c uuid_string() to lib/uuid.c -> uuid_bin_to_str() >> - disk/part_efi.c string_uuid() to lib/uuid.c -> uuid_str_to_bin() > >> diff --git a/lib/uuid.c b/lib/uuid.c > >> -void uuid_str_to_bin(const char *uuid, unsigned char *out) >> +int uuid_str_to_bin(char *uuid, unsigned char *out) >> { >> uint16_t tmp16; >> uint32_t tmp32; >> uint64_t tmp64; >> >> if (!uuid || !out) >> - return; >> + return -EINVAL; >> + >> + if (strlen(uuid) != UUID_STR_LEN) >> + return -EINVAL; > > Oh. This patch won't compile, since UUID_STR_LEN doesn't exist yet. Yup, made this '36' and fixed in 2/3. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTHfi/AAoJENk4IS6UOR1Wf9QQAIpOqG7zaURNl4I8k+9wRTe+ M9qJB9a98diBFzUzFBwciwl3xZvXEDnxTyZmoXOCWLjOn46PCqCrufSj9A7F9vvC XtOm5SQPJsteq8d2wsIqyg6CzkAv4fnQRAVQIsyY3cvOojLkqqU6tSZxI1ojNOea FBEI0XzHmAb1CH5n/Fo9wN/MWMSUN5WIZPiCAqmMECWIJ0wEFrD70SXxItc40lTY Ej7Cg9HwldlZhJ3gerlMN8MTZl+bmi2z0c0fF2vUgSa4X76s2h7xM/uKFS7VeDbO NcIFITUWBfyhkvjfJrSJdR81sWJQEjsoDVA2YwgmfkIBTkAGOOfiEP0Lt1deZ1+O vR9Dlt5lETscY76CFToOD6KlGRvZ+MKuP9Jvp8NljrOxCDevayxrWq/Vl5pwJbWs WCoQmAUplVB08aeXjw0V/ZklXJTa51THQ40O1QMSSC17EQgd/kh0D4PqAhjUJ+M2 S/gyDm2PubZOJRwXdPT9Mv+q4emY5Dn/MiY3ZMBbMeqXytMe9J+3YY/EWkcVwgFU LcbwxNKz7fqTtZkvNibuYxAjwPFqbh0/m2QxtqMtZs9aXHPT2Lno2HGcmLoaIUH/ RgCQjQjS7h+tC2NOc9OPNW+lfHFctHmkuv2GkhbGD2v0hamxJuMx8NxXVNYoClSR X9PiT5VxoZtNW/SyX9ff =QWYQ -----END PGP SIGNATURE-----