From mboxrd@z Thu Jan 1 00:00:00 1970
From: Przemyslaw Marczak
Date: Thu, 20 Mar 2014 09:42:06 +0100
Subject: [U-Boot] [PATCH v4 1/6] part_efi: move uuid<->string conversion
functions into lib/uuid.c
In-Reply-To: <20140319191921.3540D382244@gemini.denx.de>
References: <5ef7cdb8df4fb05c3c371e29d7a61e28e1563a68.1394807506.git.p.marczak@samsung.com>
<1395251911-26540-1-git-send-email-p.marczak@samsung.com>
<20140319191921.3540D382244@gemini.denx.de>
Message-ID: <532AA9DE.903@samsung.com>
List-Id:
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de
Hello,
On 03/19/2014 08:19 PM, Wolfgang Denk wrote:
> Dear Przemyslaw Marczak,
>
> In message <1395251911-26540-1-git-send-email-p.marczak@samsung.com> you wrote:
>> Changes:
>> - move uuid<->string conversion functions into lib/uuid.c so they can be
>> used by code outside part_efi.c.
>> - rename uuid_string() to uuid_bin_to_str() for consistency with existing
>> uuid_str_to_bin()
>> - add an error return code to uuid_str_to_bin()
>>
>> Update existing code to the new library functions.
>
> Please make sure to run your patches through checkpatch. Here I get
> this:
>
> WARNING: line over 80 characters
> #331: FILE: lib/uuid.c:41:
> + * GUID is used e.g. in GPT (GUID Partition Table) as a partiions unique numbers.
>
> Please fix.
>
> Best regards,
>
> Wolfgang Denk
>
Sorry for this. I will fix it in next patchset.
Are other changes acceptable?
Thank you,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com