From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 20 Mar 2014 13:08:26 -0600 Subject: [U-Boot] [PATCH 07/11] ARM: tegra: pinmux naming consistency fixes In-Reply-To: References: <1394732527-13961-1-git-send-email-swarren@wwwdotorg.org> <1394732527-13961-8-git-send-email-swarren@wwwdotorg.org> Message-ID: <532B3CAA.9060802@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/14/2014 02:15 PM, Simon Glass wrote: > Hi Stephen, > > On 13 March 2014 11:42, Stephen Warren wrote: >> From: Stephen Warren >> >> Clean up the naming of pinmux-related objects: >> * Refer to drive groups rather than pad groups to match the Linux kernel. >> * Ensure all pinmux API types are prefixed with pmux_, values (defines) >> are prefixed with PMUX_, and functions prefixed with pinmux_. >> * Modify a few type names to make their content clearer. >> * Minimal changes to SoC-specific .h/.c files are made so the code still >> compiles. A separate per-SoC change will be made immediately following, >> in order to keep individual patch size down. >> >> Signed-off-by: Stephen Warren > > Acked-by: Simon Glass > > A few comments below. >> diff --git a/arch/arm/cpu/tegra114-common/pinmux.c b/arch/arm/cpu/tegra114-common/pinmux.c >> index af8b7ca5fc79..efe5163084c1 100644 >> --- a/arch/arm/cpu/tegra114-common/pinmux.c >> +++ b/arch/arm/cpu/tegra114-common/pinmux.c >> @@ -41,7 +41,7 @@ >> #define PIN_RESERVED \ >> PIN(NONE, NONE, INVALID, INVALID, INVALID, INVALID, NONE) >> >> -const struct tegra_pingroup_desc tegra114_pingroups[PINGRP_COUNT] = { >> +const struct pmux_pingrp_desc tegra114_pingroups[PMUX_PINGRP_COUNT] = { > > Can some of these be static? Yes. I'll actually fix this in patch 5, since that patch is what introduced: const struct tegra_pingroup_desc *tegra_soc_pingroups \ = tegra114_pingroups; ... which is what allows this table to be static.