From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 6/9] i2c, davinci: add support for multiple i2c buses
Date: Mon, 24 Mar 2014 06:21:33 +0100 [thread overview]
Message-ID: <532FC0DD.3090408@denx.de> (raw)
In-Reply-To: <1395435098-30003-7-git-send-email-m-karicheri2@ti.com>
Hello Murali,
Am 21.03.2014 21:51, schrieb Murali Karicheri:
> From: Vitaly Andrianov<vitalya@ti.com>
>
> Signed-off-by: Vitaly Andrianov<vitalya@ti.com>
> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
> ---
> drivers/i2c/davinci_i2c.c | 343 +++++++++++++++++++++++++++------------------
> drivers/i2c/davinci_i2c.h | 27 ++--
> 2 files changed, 218 insertions(+), 152 deletions(-)
>
> diff --git a/drivers/i2c/davinci_i2c.c b/drivers/i2c/davinci_i2c.c
> index 6e5260c..c4a6c4d 100644
> --- a/drivers/i2c/davinci_i2c.c
> +++ b/drivers/i2c/davinci_i2c.c
> @@ -1,8 +1,9 @@
> /*
> * TI DaVinci (TMS320DM644x) I2C driver.
> *
> - * Copyright (C) 2007 Sergey Kubushyn<ksi@koi8.net>
> - *
> + * (C) Copyright 2012-2014
> + * Texas Instruments Incorporated,<www.ti.com>
> + * (C) Copyright 2007 Sergey Kubushyn<ksi@koi8.net>
> * --------------------------------------------------------
> *
> * SPDX-License-Identifier: GPL-2.0+
> @@ -12,14 +13,26 @@
> #include<i2c.h>
> #include<asm/arch/hardware.h>
> #include<asm/arch/i2c_defs.h>
> +#include<asm/io.h>
> #include "davinci_i2c.h"
>
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +static struct i2c_regs __attribute__((section(".data"))) *i2c_base =
> + (struct i2c_regs *)I2C_BASE;
> +
> +#ifdef CONFIG_I2C_MULTI_BUS
> +static unsigned int __attribute__((section(".data")))
> + bus_initialized[I2C_BUS_MAX] = { [0 ... (I2C_BUS_MAX-1)] = 0 };
> +static unsigned int __attribute__((section(".data"))) current_bus;
> +#endif
> +
NACK. Please convert this driver to the new i2c multibus/multiadapter
framework, please use CONFIG_SYS_I2C, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-03-24 5:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 20:51 [U-Boot] [PATCH v3 0/9] Add support for keystone2 SoC and K2HK EVM Murali Karicheri
2014-03-21 20:51 ` [U-Boot] [PATCH v3 1/9] fdt: call ft_board_setup_ex() at the end of image_setup_libfdt() Murali Karicheri
2014-03-22 13:33 ` Simon Glass
2014-03-21 20:51 ` [U-Boot] [PATCH v3 2/9] tools: mkimage: add support for gpimage format Murali Karicheri
2014-03-21 20:51 ` [U-Boot] [PATCH v3 3/9] arm: add support for arch timer Murali Karicheri
2014-03-21 20:51 ` [U-Boot] [PATCH v3 4/9] NAND: DaVinci: allow forced disable of subpage writes Murali Karicheri
2014-03-21 20:51 ` [U-Boot] [PATCH v3 5/9] i2c, davinci: move i2c_defs.h to the drivers/i2c directory Murali Karicheri
2014-03-21 20:51 ` [U-Boot] [PATCH v3 6/9] i2c, davinci: add support for multiple i2c buses Murali Karicheri
2014-03-24 5:21 ` Heiko Schocher [this message]
2014-03-21 20:51 ` [U-Boot] [PATCH v3 7/9] k2hk: add support for k2hk SOC and EVM Murali Karicheri
2014-03-21 20:51 ` [U-Boot] [PATCH v3 8/9] spi: davinci: add support for multiple bus and chip select Murali Karicheri
2014-03-23 11:06 ` Jagan Teki
2014-03-26 19:49 ` Karicheri, Muralidharan
2014-03-27 17:47 ` Jagan Teki
2014-03-31 20:09 ` Karicheri, Muralidharan
2014-04-01 18:40 ` Karicheri, Muralidharan
2014-03-21 20:51 ` [U-Boot] [PATCH v3 9/9] k2hk-evm: add configuration for spi1 and spi2 support Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532FC0DD.3090408@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox