From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 25 Mar 2014 14:45:02 -0600
Subject: [U-Boot] [PATCH 6/6] pxe: additionaly check for fdt_file env
 variable
In-Reply-To: <1395353581-5839-7-git-send-email-dennis@ausil.us>
References: <1392659798-1665-1-git-send-email-dennis@ausil.us>	<1395353581-5839-1-git-send-email-dennis@ausil.us>
	<1395353581-5839-7-git-send-email-dennis@ausil.us>
Message-ID: <5331EACE.70406@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/20/2014 04:13 PM, Dennis Gilmore wrote:
> some boards have used fdt_file while others have used fdtfile to
> define the name of the fdt file. If we do notget a fdtfile environment
> variable, additionally check for fdt_file.

Is this variable typically set by the user or by the default
environment? If the default environment, perhaps the variable name could
simply be changed?

Still, this change is fine by me,
Acked-by: Stephen Warren <swarren@nvidia.com

> diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c
> +			if (!f1) {
> +				f1 = getenv("fdt_file");
> +			}

Doesn't checkpatch say to remove the {} there?