public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra: make all I2C ports open-drain
Date: Wed, 26 Mar 2014 13:54:19 -0600	[thread overview]
Message-ID: <5333306B.1000803@wwwdotorg.org> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F37FF94F946@HQMAIL04.nvidia.com>

On 03/21/2014 03:27 PM, Tom Warren wrote:
> I've updated u-boot-tegra/next with this patch, rebased it against ARM master, and pushed it to Denx. All tegra boards build OK.
> 
> Albert - if you want, you can use u-boot-tegra/next to bring in this patch, or apply it to ARM master yourself, or I can do a formal PR. Let me know. Or TomR can just apply it to Denx master.

I haven't seen any response to this, so I assume simply sending a pull
request is the best way forward.

> Tom
> 
>> -----Original Message-----
>> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
>> Sent: Friday, March 21, 2014 11:31 AM
>> To: u-boot at lists.denx.de; Simon Glass; Tom Warren; Stephen Warren
>> Cc: Tom Rini
>> Subject: Re: [U-Boot] [PATCH] ARM: tegra: make all I2C ports open-drain
>>
>> On 03/12/2014 01:10 PM, Stephen Warren wrote:
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> I2C protocol requires open-drain IOs. Fix the Dalmore and Venice2
>>> pinmux tables to configure the IOs correctly. Without this, Tegra may
>>> actively drive the lines high while an external device is actively
>>> driving the lines low, which can only lead to bad things.
>>
>> Tom (or Tom or Albert),
>>
>> This one patch should really be applied as a bug-fix for v2014.04. It'd be good
>> to get it applied soon.
>>
>> The other large pinmux series I sent can obviously wait until the next release.

  reply	other threads:[~2014-03-26 19:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 19:10 [U-Boot] [PATCH] ARM: tegra: make all I2C ports open-drain Stephen Warren
2014-03-21 18:30 ` Stephen Warren
2014-03-21 21:27   ` Tom Warren
2014-03-26 19:54     ` Stephen Warren [this message]
2014-03-28 15:42       ` Tom Rini
2014-03-21 20:37 ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5333306B.1000803@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox