From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 26 Mar 2014 13:54:19 -0600 Subject: [U-Boot] [PATCH] ARM: tegra: make all I2C ports open-drain In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F37FF94F946@HQMAIL04.nvidia.com> References: <1394651444-24134-1-git-send-email-swarren@wwwdotorg.org> <532C8550.8070508@wwwdotorg.org> <5FBF8E85CA34454794F0F7ECBA79798F37FF94F946@HQMAIL04.nvidia.com> Message-ID: <5333306B.1000803@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/21/2014 03:27 PM, Tom Warren wrote: > I've updated u-boot-tegra/next with this patch, rebased it against ARM master, and pushed it to Denx. All tegra boards build OK. > > Albert - if you want, you can use u-boot-tegra/next to bring in this patch, or apply it to ARM master yourself, or I can do a formal PR. Let me know. Or TomR can just apply it to Denx master. I haven't seen any response to this, so I assume simply sending a pull request is the best way forward. > Tom > >> -----Original Message----- >> From: Stephen Warren [mailto:swarren at wwwdotorg.org] >> Sent: Friday, March 21, 2014 11:31 AM >> To: u-boot at lists.denx.de; Simon Glass; Tom Warren; Stephen Warren >> Cc: Tom Rini >> Subject: Re: [U-Boot] [PATCH] ARM: tegra: make all I2C ports open-drain >> >> On 03/12/2014 01:10 PM, Stephen Warren wrote: >>> From: Stephen Warren >>> >>> I2C protocol requires open-drain IOs. Fix the Dalmore and Venice2 >>> pinmux tables to configure the IOs correctly. Without this, Tegra may >>> actively drive the lines high while an external device is actively >>> driving the lines low, which can only lead to bad things. >> >> Tom (or Tom or Albert), >> >> This one patch should really be applied as a bug-fix for v2014.04. It'd be good >> to get it applied soon. >> >> The other large pinmux series I sent can obviously wait until the next release.